benchmark: favor === over ==#8000
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
Trott commented Aug 6, 2016
/cc @AndreasMadsen |
Contributor
mscdex commented Aug 6, 2016
LGTM |
Contributor
mscdex commented Aug 6, 2016
Member
AndreasMadsen commented Aug 6, 2016
LGTM, but I'm not sure how important it is, if we can't make it a formal rule. |
Contributor
mscdex commented Aug 6, 2016
@AndreasMadsen Well, we can't create a linter rule for it since there are legitimate uses for |
MemberAuthor
ESLint allows for exceptions when comparing to We could also enable it only for specific directories like So if we want this to be lint-enforced, there are definitely options. |
Member
addaleax commented Aug 7, 2016
LGTM |
3 similar comments
Contributor
cjihrig commented Aug 8, 2016
LGTM |
Member
jasnell commented Aug 8, 2016
LGTM |
Member
jbergstroem commented Aug 8, 2016
LGTM |
Trott added a commit to Trott/io.js that referenced this pull request Aug 9, 2016
Refs: nodejs#7961 (comment) PR-URL: nodejs#8000 Reviewed-By: Brian White <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
MemberAuthor
Trott commented Aug 9, 2016
Landed in ae25ed3 |
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
Refs: #7961 (comment) PR-URL: #8000 Reviewed-By: Brian White <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
benchmark
Description of change
Refs: #7961 (comment)