test: console constructor missing new keyword#8003
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The `console.Console()` constructor function handles a missing `new` keyword. This code is not exercised in the current tests. Add a test for this.
Trott added test 
Contributor
princejwesley commented Aug 7, 2016
LGTM |
2 similar comments
Contributor
yorkie commented Aug 7, 2016
LGTM |
Contributor
JacksonTian commented Aug 8, 2016
LGTM |
MemberAuthor
Trott commented Aug 8, 2016
Contributor
cjihrig commented Aug 8, 2016
LGTM |
Member
jasnell commented Aug 9, 2016
There was some red in the last CI run, all apparently unrelated but just in case... https://ci.nodejs.org/job/node-test-pull-request/3601/ |
MemberAuthor
Trott commented Aug 10, 2016
MemberAuthor
Trott commented Aug 10, 2016
Green, hooray! |
Trott added a commit to Trott/io.js that referenced this pull request Aug 10, 2016
The `console.Console()` constructor function handles a missing `new` keyword. This code is not exercised in the current tests. Add a test for this. PR-URL: nodejs#8003 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Yorkie Liu <[email protected]> Reviewed-By: JacksonTian - Jackson Tian <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
Trott commented Aug 10, 2016
Landed in 4c62892 |
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
The `console.Console()` constructor function handles a missing `new` keyword. This code is not exercised in the current tests. Add a test for this. PR-URL: #8003 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Yorkie Liu <[email protected]> Reviewed-By: JacksonTian - Jackson Tian <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
The `console.Console()` constructor function handles a missing `new` keyword. This code is not exercised in the current tests. Add a test for this. PR-URL: #8003 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Yorkie Liu <[email protected]> Reviewed-By: JacksonTian - Jackson Tian <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
The `console.Console()` constructor function handles a missing `new` keyword. This code is not exercised in the current tests. Add a test for this. PR-URL: #8003 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Yorkie Liu <[email protected]> Reviewed-By: JacksonTian - Jackson Tian <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
The `console.Console()` constructor function handles a missing `new` keyword. This code is not exercised in the current tests. Add a test for this. PR-URL: #8003 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Yorkie Liu <[email protected]> Reviewed-By: JacksonTian - Jackson Tian <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test console
Description of change
The
console.Console()constructor function handles a missingnewkeyword. This code is not exercised in the current tests. Add a test for
this.