Skip to content

Conversation

@lpinca
Copy link
Member

@lpincalpinca commented Aug 7, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fixes a typo in vm.runInNewContext() description.

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Aug 7, 2016
@princejwesley
Copy link
Contributor

LGTM

5 similar comments
@JungMinu
Copy link
Member

LGTM

@ChALkeR
Copy link
Member

LGTM

@addaleax
Copy link
Member

LGTM

@cjihrig
Copy link
Contributor

LGTM

@jasnell
Copy link
Member

LGTM

jasnell pushed a commit that referenced this pull request Aug 9, 2016
PR-URL: #8005 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

Landed in bb3b4d7

@jasnelljasnell closed this Aug 9, 2016
@lpincalpinca deleted the fix/typo branch August 9, 2016 18:41
@cjihrigcjihrig mentioned this pull request Aug 10, 2016
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
PR-URL: #8005 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
@cjihrigcjihrig mentioned this pull request Aug 11, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@lpinca@princejwesley@JungMinu@ChALkeR@addaleax@cjihrig@jasnell@MylesBorins@nodejs-github-bot