inspector: Fix failing test

[eugeneo]

Checklist

• make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

This change only touches inspector test.

Description of change

Test was updated to wait till the inspector processes socket closure.

CC: @ofrobots

[addaleax]

This looked okay to me? reinterpret_cast<…>() is an argument to uv_is_active, not EXPECT_EQ

[eugeneo]

Right. I reverted the change.

[ofrobots]

nit: since this is fixing a test, the commit message should probably use the 'test: ' prefix. Otherwise LGTM.

CI: https://ci.nodejs.org/job/node-test-pull-request/3582/. I have verified locally that this fixes #8006.

/cc @bnoordhuis as well.

[eugeneo]

Thank you for the review. I updated the commit message.

[bnoordhuis]

LGTM but can you update the commit log status line to e.g. test: fix failing inspector cctest?

I admit I don't understand why the test passes for me locally with and without this change.

[eugeneo]

@bnoordhuis I updated the message.

This test failure was intermittent - it looks like sockets closing on Mac is somehow more "async" then on other systems (or simply slower) so this test failed because the cleanup code saw inspector socket as still open. If I added a delay (e.g. printed a message to stderr) the test succeeded.

[ofrobots]

Landed as 49e473a.