Skip to content

Conversation

@bnoordhuis
Copy link
Member

Visual Studio 2013 is no longer supported. Update the Windows build
prerequisites.

Refs: #7484

Visual Studio 2013 is no longer supported. Update the Windows build prerequisites. Refs: nodejs#7484
@bnoordhuisbnoordhuis added doc Issues and PRs related to the documentations. windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Aug 10, 2016
@jasnell
Copy link
Member

LGTM

@joaocgreis
Copy link
Member

Why the update 3? Any VS2015 should do.

@bnoordhuis
Copy link
MemberAuthor

Mostly because I don't want to be chasing bugs in older updates, same when I tell people to upgrade to gcc 4.8.5 when they hit a bug with 4.8.0.

@joaocgreis
Copy link
Member

LGTM

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Aug 11, 2016
We can remove some Visual Studio 2013-specific workarounds now that support for that compiler has officially been dropped. Refs: nodejs#7484 Refs: nodejs#8049
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Aug 11, 2016
Support for Visual Studio 2013 has officially been dropped, remove the build option for that compiler. Refs: nodejs#7484 Refs: nodejs#8049
jasnell pushed a commit that referenced this pull request Aug 12, 2016
Visual Studio 2013 is no longer supported. Update the Windows build prerequisites. Refs: #7484 PR-URL: #8049 Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]>
@jasnell
Copy link
Member

Landed in b948744

@jasnelljasnell closed this Aug 12, 2016
cjihrig pushed a commit that referenced this pull request Aug 15, 2016
Visual Studio 2013 is no longer supported. Update the Windows build prerequisites. Refs: #7484 PR-URL: #8049 Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]>
@cjihrigcjihrig mentioned this pull request Aug 15, 2016
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Sep 23, 2016
We can remove some Visual Studio 2013-specific workarounds now that support for that compiler has officially been dropped. PR-URL: nodejs#8067 Refs: nodejs#7484 Refs: nodejs#8049 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joao Reis <[email protected]>
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Sep 23, 2016
Support for Visual Studio 2013 has officially been dropped, remove the build option for that compiler. PR-URL: nodejs#8067 Refs: nodejs#7484 Refs: nodejs#8049 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joao Reis <[email protected]>
jasnell pushed a commit that referenced this pull request Sep 29, 2016
We can remove some Visual Studio 2013-specific workarounds now that support for that compiler has officially been dropped. PR-URL: #8067 Refs: #7484 Refs: #8049 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joao Reis <[email protected]>
jasnell pushed a commit that referenced this pull request Sep 29, 2016
Support for Visual Studio 2013 has officially been dropped, remove the build option for that compiler. PR-URL: #8067 Refs: #7484 Refs: #8049 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joao Reis <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
We can remove some Visual Studio 2013-specific workarounds now that support for that compiler has officially been dropped. PR-URL: #8067 Refs: #7484 Refs: #8049 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joao Reis <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
Support for Visual Studio 2013 has officially been dropped, remove the build option for that compiler. PR-URL: #8067 Refs: #7484 Refs: #8049 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joao Reis <[email protected]>
@gibfahngibfahn mentioned this pull request Nov 7, 2017
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@bnoordhuis@jasnell@joaocgreis@MylesBorins