doc: move orangemocha to collaborators list#8062
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
addaleax commented Aug 11, 2016
LGTM :/ |
Member
jbergstroem commented Aug 11, 2016
LGTM. Thanks for all your CTC-work up to here, Alexis! |
Contributor
cjihrig commented Aug 11, 2016
LGTM |
Trott added a commit to Trott/io.js that referenced this pull request Aug 11, 2016
PR-URL: nodejs#8062 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MemberAuthor
Trott commented Aug 11, 2016
I think this meets the requirements for exclusion from the 48 hour rule, so... Landed in ba3ccec |
Contributor
thefourtheye commented Aug 11, 2016
It would be better if we include the reason as well. |
Member
Yes, this should have included something like «self-resignation» in the commit message. |
Member
mhdawson commented Aug 11, 2016
LGTM |
cjihrig pushed a commit that referenced this pull request Aug 11, 2016
PR-URL: #8062 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Contributor
orangemocha commented Aug 13, 2016
Thanks, Rich. And for the record, I did resign myself. |
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
PR-URL: #8062 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
PR-URL: #8062 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #8062 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #8062 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
I IRC'ed with @orangemocha before doing this. He's doing other things right now and didn't think he'd get to this until next week anyway, and was fine with me doing it for him. Since I'm tidying up one or two other .md files right now...