tools: enable rest-spread-spacing#8073
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There are currently 17 instances of the spread operator and all of them have no space between the operator and the subsequent argument. This change enables a lint rule to enforce that same style on any future uses of the spread operator. Refs: https://github.com/nodejs/node/pull/6573/files/7a1b47f329f2e6481ef8f54951570197fd98378d#r74479351
MemberAuthor
Trott commented Aug 11, 2016
/cc @Fishrock123 |
Contributor
cjihrig commented Aug 11, 2016
LGTM |
1 similar comment
Member
jasnell commented Aug 11, 2016
LGTM |
MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/3633/ (Lots of red in other CI jobs right now, hopefully because people are testing experimental changes or something and not because something is on fire...) |
Member
jasnell commented Aug 11, 2016
@Trott ... the CI has been extremely flaky here lately. Lots of red causing folks to have to do multiple runs. /cc @nodejs/build |
Member
targos commented Aug 12, 2016
LGTM |
2 similar comments
Member
ChALkeR commented Aug 12, 2016
LGTM |
Contributor
silverwind commented Aug 12, 2016
LGTM |
Member
jbergstroem commented Aug 14, 2016
LGTM - Aix unrelated |
Trott added a commit that referenced this pull request Aug 15, 2016
There are currently 17 instances of the spread operator and all of them have no space between the operator and the subsequent argument. This change enables a lint rule to enforce that same style on any future uses of the spread operator. Refs: https://github.com/nodejs/node/pull/6573/files/7a1b47f329f2e6481ef8f54951570197fd98378d#r74479351 PR-URL: #8073 Reviewed-By: cjihrig - Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
MemberAuthor
Trott commented Aug 15, 2016
Landed in cb2e83e |
cjihrig pushed a commit that referenced this pull request Aug 15, 2016
There are currently 17 instances of the spread operator and all of them have no space between the operator and the subsequent argument. This change enables a lint rule to enforce that same style on any future uses of the spread operator. Refs: https://github.com/nodejs/node/pull/6573/files/7a1b47f329f2e6481ef8f54951570197fd98378d#r74479351 PR-URL: #8073 Reviewed-By: cjihrig - Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tools
Description of change
There are currently 17 instances of the spread operator and all of them
have no space between the operator and the subsequent argument. This
change enables a lint rule to enforce that same style on any future uses
of the spread operator.
Refs: https://github.com/nodejs/node/pull/6573/files/7a1b47f329f2e6481ef8f54951570197fd98378d#r74479351