Skip to content

Conversation

@mhdawson
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

exclude tests for AIX in 4.x stream now that
its been added to regular regression runs. This
will avoid known failures from making the build
look RED while also being able to catch any
new regressions if they are introduced.

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Aug 12, 2016
@joaocgreis
Copy link
Member

LGTM

CI: https://ci.nodejs.org/job/node-test-pull-request/3641/

As with #8065 , I believe this can be landed quickly.

cc @nodejs/lts

@jasnell
Copy link
Member

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you capitalize "disable".

@cjihrig
Copy link
Contributor

LGTM

Exclude tests for AIX in 4.x stream now that its been added to regular regression runs. This will avoid known failures from making the build look RED while also being able to catch any new regressions if they are introduced.
mhdawson added a commit that referenced this pull request Aug 25, 2016
Exclude tests for AIX in 4.x stream now that its been added to regular regression runs. This will avoid known failures from making the build look RED while also being able to catch any new regressions if they are introduced. PR-URL: #8076 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joao Reis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@mhdawson
Copy link
MemberAuthor

Landed as: 4bfb247

MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
Exclude tests for AIX in 4.x stream now that its been added to regular regression runs. This will avoid known failures from making the build look RED while also being able to catch any new regressions if they are introduced. PR-URL: #8076 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joao Reis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Exclude tests for AIX in 4.x stream now that its been added to regular regression runs. This will avoid known failures from making the build look RED while also being able to catch any new regressions if they are introduced. PR-URL: #8076 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joao Reis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Exclude tests for AIX in 4.x stream now that its been added to regular regression runs. This will avoid known failures from making the build look RED while also being able to catch any new regressions if they are introduced. PR-URL: #8076 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joao Reis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
@mhdawsonmhdawson deleted the v4xaixflaky branch March 15, 2017 21:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@mhdawson@joaocgreis@jasnell@cjihrig@MylesBorins@nodejs-github-bot