tools: update ESLint to 3.3.0 and enable rules#8097
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Change `require ('zlib');` to `require('zlib');` in conformance with style in the rest of the code base. This is in preparation for enabling linting for that issue.Update ESLint 3.3.0 and update .eslintrc: * replace deprecated no-negated-in-lhs rule with no-unsafe-negation * http://eslint.org/docs/rules/no-negated-in-lhs * http://eslint.org/docs/rules/no-unsafe-negation * enable no-template-curly-in-string * http://eslint.org/docs/rules/no-template-curly-in-string * enable no-global-assign * http://eslint.org/docs/rules/no-global-assign * enable func-call-spacing * http://eslint.org/docs/rules/func-call-spacing
Trott added test 
Member
targos commented Aug 14, 2016
first commit LGTM. rubber stamp LGTM for the ESLint update |
Member
targos commented Aug 14, 2016
Member
jasnell commented Aug 15, 2016
LGTM |
1 similar comment
Contributor
silverwind commented Aug 16, 2016
LGTM |
Contributor
cjihrig commented Aug 16, 2016
ESLint v3.3.1 has been released since this PR was opened. |
MemberAuthor
Trott commented Aug 16, 2016
@cjihrig I don't think any of the bug fixes are relevant to our code base. Happy to bump if anyone feels strongly that we ought to, but just as happy to leave it at 3.3.0 and update the next time there's something relevant in the new release. |
Contributor
cjihrig commented Aug 16, 2016
No strong opinion. I just thought I'd mention it while this PR is open. |
MemberAuthor
Trott commented Aug 16, 2016
Trott added a commit that referenced this pull request Aug 16, 2016
Change `require ('zlib');` to `require('zlib');` in conformance with style in the rest of the code base. This is in preparation for enabling linting for that issue. PR-URL: #8097 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>Trott added a commit that referenced this pull request Aug 16, 2016
Update ESLint 3.3.0 and update .eslintrc: * replace deprecated no-negated-in-lhs rule with no-unsafe-negation * http://eslint.org/docs/rules/no-negated-in-lhs * http://eslint.org/docs/rules/no-unsafe-negation * enable no-template-curly-in-string * http://eslint.org/docs/rules/no-template-curly-in-string * enable no-global-assign * http://eslint.org/docs/rules/no-global-assign * enable func-call-spacing * http://eslint.org/docs/rules/func-call-spacing PR-URL: #8097 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
evanlucas pushed a commit that referenced this pull request Aug 20, 2016
Change `require ('zlib');` to `require('zlib');` in conformance with style in the rest of the code base. This is in preparation for enabling linting for that issue. PR-URL: #8097 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>evanlucas pushed a commit that referenced this pull request Aug 20, 2016
Update ESLint 3.3.0 and update .eslintrc: * replace deprecated no-negated-in-lhs rule with no-unsafe-negation * http://eslint.org/docs/rules/no-negated-in-lhs * http://eslint.org/docs/rules/no-unsafe-negation * enable no-template-curly-in-string * http://eslint.org/docs/rules/no-template-curly-in-string * enable no-global-assign * http://eslint.org/docs/rules/no-global-assign * enable func-call-spacing * http://eslint.org/docs/rules/func-call-spacing PR-URL: #8097 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Contributor
MylesBorins commented Oct 10, 2016
@Trott I'm opting to not land this as it is. If you would like to send a PR updating the linter on v4.x and updating the rules that would be rad, but not neccessary |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tools test
Description of change
In one test, change
require ('zlib');torequire('zlib');in conformance with style in the rest of the code base. This is to conform withfunc-call-spacingand the prevailing style in the rest of the code base.