doc: fix variable scoping bug in Stream HTTP server example code#8124
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
doc/api/stream.md Outdated
Member
There was a problem hiding this comment.
nit: our preferred code style in core is to require parens around arguments in arrow functions.
Member
jasnell commented Aug 16, 2016
LGTM with a nit |
Const is block scoped.
lazlojulyforce-pushed the doc-stream-http-example-fix branch from 6b07664 to 061880fCompare
Contributor
MylesBorins commented Aug 16, 2016
LGTM |
jasnell pushed a commit that referenced this pull request Aug 18, 2016
Const is block scoped. PR-URL: #8124 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Member
jasnell commented Aug 18, 2016
Landed in 66d697c! thank you @lazlojuly ! |
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
Const is block scoped. PR-URL: #8124 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
Const is block scoped. PR-URL: #8124 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Const is block scoped. PR-URL: #8124 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Const is block scoped. PR-URL: #8124 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Const is block scoped. PR-URL: #8124 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Const is block-scoped.
Stream HTTP server example code is broken since
constwas introduced inside a try block.