test: fix assertion in test-watch-file.js#8129
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added fs 
Contributor
Fishrock123 commented Aug 16, 2016
lgtm |
Member
targos commented Aug 17, 2016
LGTM s/notDeepStringEqual/notDeepStrictEqual/ in the commit message |
Because it is comparing two Date objects, an assertion in test/pummel/test-watch-file.js would never fire even if the two objects represented the same time. Use `assert.notDeepStrictEqual()` so that the assertion fires if different Date objects represent the same time.
Member
jasnell commented Aug 17, 2016
LGTM |
1 similar comment
Contributor
cjihrig commented Aug 17, 2016
LGTM |
MemberAuthor
Trott commented Aug 18, 2016
Trott added a commit to Trott/io.js that referenced this pull request Aug 18, 2016
Because it is comparing two Date objects, an assertion in test/pummel/test-watch-file.js would never fire even if the two objects represented the same time. Use `assert.notDeepStrictEqual()` so that the assertion fires if different Date objects represent the same time. PR-URL: nodejs#8129 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
Trott commented Aug 18, 2016
Landed in 5eb0ca7 |
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
Because it is comparing two Date objects, an assertion in test/pummel/test-watch-file.js would never fire even if the two objects represented the same time. Use `assert.notDeepStrictEqual()` so that the assertion fires if different Date objects represent the same time. PR-URL: #8129 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Because it is comparing two Date objects, an assertion in test/pummel/test-watch-file.js would never fire even if the two objects represented the same time. Use `assert.notDeepStrictEqual()` so that the assertion fires if different Date objects represent the same time. PR-URL: #8129 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Because it is comparing two Date objects, an assertion in test/pummel/test-watch-file.js would never fire even if the two objects represented the same time. Use `assert.notDeepStrictEqual()` so that the assertion fires if different Date objects represent the same time. PR-URL: #8129 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Because it is comparing two Date objects, an assertion in test/pummel/test-watch-file.js would never fire even if the two objects represented the same time. Use `assert.notDeepStrictEqual()` so that the assertion fires if different Date objects represent the same time. PR-URL: #8129 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test fs
Description of change
Because it is comparing two Date objects, an assertion in
test/pummel/test-watch-file.js would never fire even if the two objects
represented the same time. Use
assert.notDeepStringEqual()so that theassertion fires if different Date objects represent the same time.