Revert "repl,util: insert carriage returns in output"#8143
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added repl 
Member
addaleax commented Aug 17, 2016
(The |
ContributorAuthor
evanlucas commented Aug 17, 2016
Just tried it on #8141. It doesn't rebase it, so it had +250 commits in the PR |
Member
addaleax commented Aug 17, 2016
That’s unfortunate… well, this one LGTM then. |
Member
targos commented Aug 17, 2016
@evanlucas I suppose you can rebase manually, force push and then change the base branch |
3 tasks
Member
jasnell commented Aug 17, 2016
Why does this need to be reverted in master? Did it land in v6? If so, it would only need to be reverted in v6. |
Contributor
yorkie commented Aug 17, 2016
Contributor
mscdex commented Aug 17, 2016
FWIW I didn't recall seeing |
2 tasks
ContributorAuthor
evanlucas commented Aug 17, 2016
Contributor
Fishrock123 commented Aug 19, 2016
seems good to me, what still needs to be discussed? |
Member
jasnell commented Aug 19, 2016
LGTM |
This reverts commit fce4b98. This was a breaking change and should have been marked semver-major. The change that was made altered the output of util.format() and util.inspect(). With how much those are used in the wild, this type of change deserves more justification. Fixes: nodejs#8138 PR-URL: nodejs#8143 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
ContributorAuthor
evanlucas commented Aug 19, 2016
Landed in 7600707. Thanks! |
evanlucas added a commit that referenced this pull request Aug 20, 2016
This reverts commit fce4b98. This was a breaking change and should have been marked semver-major. The change that was made altered the output of util.format() and util.inspect(). With how much those are used in the wild, this type of change deserves more justification. Fixes: #8138 PR-URL: #8143 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas added a commit that referenced this pull request Aug 24, 2016
Notable changes: * **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154 * **inspector**: * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021 * add support for uncaught exception (Aleksei Koziatinskii) #8043 * **meta**: add @joshgav to collaborators (Josh Gavant) #8146 * **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145 * ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143
evanlucas added a commit that referenced this pull request Aug 26, 2016
Notable changes: * **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154 * **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054 * **inspector**: * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021 * add support for uncaught exception (Aleksei Koziatinskii) #8043 * **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145 * ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143 PR-URL: #8253
evanlucas added a commit that referenced this pull request Aug 26, 2016
Notable changes: * **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154 * **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054 * **inspector**: * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021 * add support for uncaught exception (Aleksei Koziatinskii) #8043 * **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145 * ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143 PR-URL: #8253
evanlucas added a commit that referenced this pull request Aug 26, 2016
Notable changes: * **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154 * **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054 * **inspector**: * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021 * add support for uncaught exception (Aleksei Koziatinskii) #8043 * **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145 * ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143 PR-URL: #8253
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
repl,util
Description of change
This reverts commit fce4b98.
This was a breaking change and should have been marked semver-major.
Ref: #8028
Related: hapijs/code#81
Related: #8138
I realized I had opened the other targeting v6.x instead of master