test: add missing assert.deepEqual() test case#8152
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added assert 
Member
jasnell commented Aug 18, 2016
LGTM |
Member
addaleax commented Aug 18, 2016
Contributor
cjihrig commented Aug 18, 2016
LGTM |
MemberAuthor
Trott commented Aug 18, 2016
Jenkins error on Windows CI. Running CI again: https://ci.nodejs.org/job/node-test-pull-request/3725/ |
None of the existing tests checked for the situation where `assert.deepEqual()` receives two objects that have the same number of keys but different key names. Therefore, line 242 of `lib/assert.js` was not being exercised by any tests. This change adds the missing test case. PR-URL: nodejs#8152 Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Aug 19, 2016
None of the existing tests checked for the situation where `assert.deepEqual()` receives two objects that have the same number of keys but different key names. Therefore, line 242 of `lib/assert.js` was not being exercised by any tests. This change adds the missing test case. PR-URL: nodejs#8152 Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
Trott commented Aug 19, 2016
Landed in de3d805 |
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
None of the existing tests checked for the situation where `assert.deepEqual()` receives two objects that have the same number of keys but different key names. Therefore, line 242 of `lib/assert.js` was not being exercised by any tests. This change adds the missing test case. PR-URL: #8152 Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
None of the existing tests checked for the situation where `assert.deepEqual()` receives two objects that have the same number of keys but different key names. Therefore, line 242 of `lib/assert.js` was not being exercised by any tests. This change adds the missing test case. PR-URL: #8152 Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
None of the existing tests checked for the situation where `assert.deepEqual()` receives two objects that have the same number of keys but different key names. Therefore, line 242 of `lib/assert.js` was not being exercised by any tests. This change adds the missing test case. PR-URL: #8152 Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
None of the existing tests checked for the situation where `assert.deepEqual()` receives two objects that have the same number of keys but different key names. Therefore, line 242 of `lib/assert.js` was not being exercised by any tests. This change adds the missing test case. PR-URL: #8152 Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test assert
Description of change
None of the existing tests checked for the situation where
assert.deepEqual()receives two objects that have the same number ofkeys but different key names. Therefore, line 242 of
lib/assert.jswasnot being exercised by any tests.
This change adds the missing test case.
Refs: https://node-core-coverage.addaleax.net/coverage-05b566a5ef7c41f6/root/assert.js.html