Skip to content

Conversation

@cjihrig
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

This error was previously not covered. This commit adds coverage.

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Aug 18, 2016
@cjihrigcjihrig added the child_process Issues and PRs related to the child_process subsystem. label Aug 18, 2016
@Trott
Copy link
Member

LGTM if CI is green

@santigimeno
Copy link
Member

This error was previously not covered. This commit adds coverage. PR-URL: nodejs#8159 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
@cjihrigcjihrig merged commit ae4ce9f into nodejs:masterAug 20, 2016
@cjihrigcjihrig deleted the test branch August 20, 2016 20:17
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
This error was previously not covered. This commit adds coverage. PR-URL: #8159 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
This error was previously not covered. This commit adds coverage. PR-URL: #8159 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
This error was previously not covered. This commit adds coverage. PR-URL: #8159 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
This error was previously not covered. This commit adds coverage. PR-URL: #8159 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
This error was previously not covered. This commit adds coverage. PR-URL: #8159 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
This error was previously not covered. This commit adds coverage. PR-URL: #8159 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_processIssues and PRs related to the child_process subsystem.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cjihrig@Trott@santigimeno@MylesBorins@nodejs-github-bot