test: refactor test-util-inspect#8189
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* favor `assert.strictEqual()` and friends of `assert.equal()` etc. * favor `.includes()` over `.indexOf()` for existence checks
Trott added util 
Member
fhinkel commented Aug 21, 2016
Member
fhinkel commented Aug 21, 2016
LGTM |
test/parallel/test-util-inspect.js Outdated
| assert.ok(ex.indexOf('[message]')!=-1); | ||
| assert.strictEqual(ex.includes('Error: FAIL'),true); | ||
| assert.strictEqual(ex.includes('[stack]'),true); | ||
| assert.strictEqual(ex.includes('[message]'),true); |
Member
There was a problem hiding this comment.
No need to change these but I think it's a good case for assert.ok()
Member
targos commented Aug 21, 2016
LGTM |
1 similar comment
Member
jasnell commented Aug 21, 2016
LGTM |
Member
addaleax commented Aug 22, 2016
@jbergstroem fyi, the CI run was green but the build status here is shown as pending |
Member
@addaleax probably need to revisit logic regarding flaky. |
MemberAuthor
Trott commented Aug 22, 2016
Did the |
MemberAuthor
Trott commented Aug 23, 2016
CI issues are a soon-to-be-reverted known-flaky and one build failure. |
Trott added a commit to Trott/io.js that referenced this pull request Aug 23, 2016
* favor `assert.strictEqual()` and friends of `assert.equal()` etc. * favor `.includes()` over `.indexOf()` for existence checks PR-URL: nodejs#8189 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
Trott commented Aug 23, 2016
Landed in e3cb0bf |
4 tasks
Closed
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 7, 2016
* favor `assert.strictEqual()` and friends of `assert.equal()` etc. * favor `.includes()` over `.indexOf()` for existence checks PR-URL: nodejs#8189 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
* favor `assert.strictEqual()` and friends of `assert.equal()` etc. * favor `.includes()` over `.indexOf()` for existence checks PR-URL: nodejs#8189 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: nodejs#8437 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
* favor `assert.strictEqual()` and friends of `assert.equal()` etc. * favor `.includes()` over `.indexOf()` for existence checks PR-URL: nodejs#8189 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Refs: nodejs#8437 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test util
Description of change
assert.strictEqual()and friends ofassert.equal()etc..includes()over.indexOf()for existence checks