Skip to content

Conversation

@yorkie
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

async_wrap, test

Description of change

This covers this line in "src/async-wrap.cc". /R= @trevnorris

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Aug 20, 2016
@jasnell
Copy link
Member

@jasnell
Copy link
Member

LGTM if CI is green.

@yorkie
Copy link
ContributorAuthor

The CI seems to fail on the following errors:

@yorkie
Copy link
ContributorAuthor

@jasnell The arm-fanned issue seems to be tried to fix at #8203, but another seems fresh, so I opened #8219 to track that.

@trevnorris
Copy link
Contributor

LGTM

@yorkie
Copy link
ContributorAuthor

@yorkieyorkieforce-pushed the test-async-wrap-throw-no-init branch from c49a070 to 10b3f13CompareAugust 25, 2016 19:54
@yorkieyorkie merged commit 10b3f13 into nodejs:masterAug 25, 2016
@yorkieyorkie deleted the test-async-wrap-throw-no-init branch August 25, 2016 19:56
@yorkie
Copy link
ContributorAuthor

Landed at 10b3f13, thanks for reviews :)

@yorkie
Copy link
ContributorAuthor

yorkie commented Aug 25, 2016

Needs help with the CI failure, the CI seems to fail on AIX, here is the log of failed build. I remember that this CI#3815 was green but now it has failure. /cc @nodejs/build

@Fishrock123Fishrock123 mentioned this pull request Sep 6, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@MylesBorins
Copy link
Contributor

I've landed this on v4.x-staging. @trevnorris@yorkie let me know if it should not have landed

MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
rvagg pushed a commit that referenced this pull request Oct 18, 2016
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@yorkie@jasnell@trevnorris@MylesBorins@nodejs-github-bot