Skip to content

Conversation

@lpinca
Copy link
Member

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

@nodejs-github-botnodejs-github-bot added util Issues and PRs related to the built-in util module. doc Issues and PRs related to the documentations. labels Aug 21, 2016
doc/api/util.md Outdated
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is when the module has been renamed. It was called sys before, not sure if it's better to show when the method was added to sys.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think of the added marks as a reference for the user to understand "how far back can I expect this thing to be in this place", so existence elsewhere before then is kind of irrelevant.

@silverwind
Copy link
Contributor

LGTM

3 similar comments
@jasnell
Copy link
Member

LGTM

@Qard
Copy link
Member

Qard commented Aug 22, 2016

LGTM

@bengl
Copy link
Member

LGTM

jasnell pushed a commit that referenced this pull request Aug 23, 2016
PR-URL: #8206 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Bryan English <[email protected]>
@jasnell
Copy link
Member

Landed in 16f4b8e

@jasnelljasnell closed this Aug 23, 2016
@lpincalpinca deleted the add/added-util branch August 23, 2016 18:37
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
PR-URL: #8206 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Bryan English <[email protected]>
@lpincalpinca mentioned this pull request Aug 26, 2016
2 tasks
@MylesBorins
Copy link
Contributor

This doesn't land cleanly on v4.x please feel free to manually backport

lpinca added a commit to lpinca/node that referenced this pull request Oct 1, 2016
PR-URL: nodejs#8206 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Bryan English <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 4, 2016
Ref: #8881 PR-URL: #8206 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Bryan English <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Ref: #8881 PR-URL: #8206 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Bryan English <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Ref: #8881 PR-URL: #8206 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Bryan English <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Ref: #8881 PR-URL: #8206 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Bryan English <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.utilIssues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@lpinca@silverwind@jasnell@Qard@bengl@MylesBorins@Fishrock123@nodejs-github-bot