Skip to content

Conversation

@rvagg
Copy link
Member

This was voted on the CTC meeting this week so this PR just needs review, @thealphanerd can you check pls?

Congrats btw!

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 24, 2016
@ChALkeR
Copy link
Member

ChALkeR commented Aug 24, 2016

LGTM

Upd: yes, with removing the duplicate entry under Collaborators as @addaleax noted.

@addaleax
Copy link
Member

I think Myles should be moved from the Collaborators list to the CTC members list, LGTM with that (and if @thealphanerd is happy with this, of course 😄)

And yep, congratulations!

@jasnell
Copy link
Member

+1 to the nit from @addaleax ... otherwise LGTM

@MylesBorins
Copy link
Contributor

thank you all so much. very honored to be included!

On Wed, Aug 24, 2016, 9:03 PM James M Snell [email protected]
wrote:

+1 to the nit from @addaleaxhttps://github.com/addaleax ... otherwise
LGTM


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8260 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV-sZHhNAydx0sJiVxXP70HY2Lce2ks5qjLGugaJpZM4JsccE
.

@MylesBorins
Copy link
Contributor

also, lgtm

@jasnell
Copy link
Member

pretty certain this one doesn't need the 48 hours... landing

@jasnell
Copy link
Member

jasnell commented Aug 25, 2016

Landed in 36086b2

@jasnelljasnell closed this Aug 25, 2016
jasnell pushed a commit that referenced this pull request Aug 25, 2016
PR-URL: #8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
@Trott
Copy link
Member

Looks like this was re-landed in 2367e6c with a force push.

@jasnell
Copy link
Member

yep... accidentally botched the first one... thanks for updating the pr

@Fishrock123Fishrock123 mentioned this pull request Sep 6, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
PR-URL: nodejs#8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
PR-URL: #8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
PR-URL: #8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
PR-URL: #8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
rvagg added a commit that referenced this pull request Oct 18, 2016
PR-URL: #8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #8260 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@rvagg@ChALkeR@addaleax@jasnell@MylesBorins@Trott@nodejs-github-bot