test: favor === over in == in http test#8471
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
addaleax commented Sep 9, 2016
LGTM, thank you! :) By the way, your author name in this commit is given as “jun-oka”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you. |
Contributor
cjihrig commented Sep 9, 2016
LGTM |
ContributorAuthor
@addaleax Thank you for that info! In that case, I prefer to use "Junshu Okamoto". |
Member
addaleax commented Sep 9, 2016
@jun-oka I guess @Trott is around somewhere and can help you, but usually, you can update the commit here yourself. It goes something like this: git config --global user.name 'Junshu Okamoto'# (leave out the --global if you only want this for Node) git commit --amend --reset-author git push --force-with-lease(git magic! 😄) |
test/parallel/test-http.js Outdated
Member
There was a problem hiding this comment.
Can you update assert.equal() here and elsewhere to use assert.strictEqual() instead? Might as well get all our minor refactoring in at once. :-D
jun-okaforce-pushed the test-http-eqeqeq branch from bacf52e to 42a2e81CompareContributorAuthor
jun-oka commented Sep 9, 2016
Member
Trott commented Sep 9, 2016
LGTM if CI doesn't reveal any surprises. |
Member
Trott commented Sep 9, 2016
ContributorAuthor
jun-oka commented Sep 9, 2016
It seems unrelated error, I hope. |
Member
lpinca commented Sep 10, 2016
The |
test/parallel/test-http.js Outdated
Contributor
There was a problem hiding this comment.
Now that you are doing this, why don't you change the requires as well.
ContributorAuthor
There was a problem hiding this comment.
@thefourtheye That's right. Let me do that.
Member
jasnell commented Sep 12, 2016
LGTM |
jun-okaforce-pushed the test-http-eqeqeq branch from 21f2b7d to b05c4e8CompareContributorAuthor
jun-oka commented Sep 13, 2016
I updated :) |
Member
Trott commented Sep 13, 2016
ContributorAuthor
jun-oka commented Sep 13, 2016
Hmm error again. |
Member
Trott commented Sep 13, 2016
Errors in CI are unrelated build issues and one known flaky. |
Trott pushed a commit to Trott/io.js that referenced this pull request Sep 13, 2016
* favor ’===’ over in ’==’ * favor ’assert.strictEqual’ over ’assert.equal’ * favor ’const’ over ’var’ PR-URL: nodejs#8471 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
Trott commented Sep 13, 2016
Landed in 7f2c9ba |
ContributorAuthor
jun-oka commented Sep 13, 2016
Thank you Trott |
Fishrock123 pushed a commit that referenced this pull request Sep 14, 2016
* favor ’===’ over in ’==’ * favor ’assert.strictEqual’ over ’assert.equal’ * favor ’const’ over ’var’ PR-URL: #8471 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 6, 2016
* favor ’===’ over in ’==’ * favor ’assert.strictEqual’ over ’assert.equal’ * favor ’const’ over ’var’ PR-URL: #8471 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
* favor ’===’ over in ’==’ * favor ’assert.strictEqual’ over ’assert.equal’ * favor ’const’ over ’var’ PR-URL: #8471 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
* favor ’===’ over in ’==’ * favor ’assert.strictEqual’ over ’assert.equal’ * favor ’const’ over ’var’ PR-URL: #8471 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
* favor ’===’ over in ’==’ * favor ’assert.strictEqual’ over ’assert.equal’ * favor ’const’ over ’var’ PR-URL: #8471 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test http
Description of change