Skip to content

test: cleanup test-http-agent-destroyed-socket#8583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
canastro wants to merge 2 commits into from
Closed

test: cleanup test-http-agent-destroyed-socket #8583

canastro wants to merge 2 commits into from

Conversation

@canastro
Copy link

@canastrocanastro commented Sep 17, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Changed vars to const / let, functions to arrow functions and use strictEqual and notStrictEqual where appropriate.

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Sep 17, 2016
@mscdexmscdex added the http Issues or PRs related to the http subsystem. label Sep 17, 2016
eljefedelrodeodeljefe
eljefedelrodeodeljefe suggested changes Sep 17, 2016
View reviewed changes
Copy link
Contributor

@eljefedelrodeodeljefeeljefedelrodeodeljefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit. Can you please include the description of change into the commit message.

@canastro
Copy link
Author

canastro commented Sep 17, 2016

I'll have to close this one, because I found a issue when trying out the common.mustCall, issue created here: #8613

@alisccoaliscco mentioned this pull request Jun 21, 2023
Open
This was referenced Jul 1, 2023
Open
Open
This was referenced Jul 8, 2023
Open
Open
@leonardoadameleonardoadame mentioned this pull request Sep 30, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eljefedelrodeodeljefeeljefedelrodeodeljefeeljefedelrodeodeljefe requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@canastro@eljefedelrodeodeljefe@mscdex@nodejs-github-bot