test: add expectDeprecationWarning to common#8662
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
mscdex commented Sep 20, 2016
Minor nit: typo in commit message: s/emmited/emitted/ |
targosforce-pushed the test-common-deprecation branch from aa65c45 to 12975d8Compare
MemberAuthor
targos commented Sep 20, 2016
addaleax approved these changes Sep 20, 2016
targosforce-pushed the test-common-deprecation branch from 12975d8 to 6400559CompareMemberAuthor
targos commented Sep 20, 2016
@addaleax I forgot about your comment in #8633 (comment). Changed to use |
Member
addaleax commented Sep 20, 2016
Oh, right. Still LGTM! |
Member
benjamingr commented Sep 20, 2016
LGTM |
benjamingr approved these changes Sep 20, 2016
Member
Trott commented Sep 20, 2016
LGTM if there are no surprises in CI |
cjihrig approved these changes Sep 20, 2016
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
LGTM
One suggestion. Since we've been getting a little warning-happy lately, perhaps this function should be expectWarning() with the name as an argument.
targosforce-pushed the test-common-deprecation branch from 6400559 to a2668a9CompareMemberAuthor
targos commented Sep 22, 2016
I made the suggested change from @cjihrig. |
Member
jasnell commented Sep 24, 2016
I think this works for now. We'll want to be careful in the case where a particular code path expects multiple warnings, but that's a change we can make later as it becomes necessary. |
MemberAuthor
targos commented Sep 24, 2016
CI before landing: https://ci.nodejs.org/job/node-test-pull-request/4256/ |
There are multiple tests that use the same boilerplate to test that warnings are correctly emitted. This adds a new common function to do that and changes the tests to use it. PR-URL: nodejs#8662 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targosforce-pushed the test-common-deprecation branch from a2668a9 to fb651d3Comparetargos added a commit that referenced this pull request Sep 24, 2016
There are multiple tests that use the same boilerplate to test that warnings are correctly emitted. This adds a new common function to do that and changes the tests to use it. PR-URL: #8662 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
targos commented Sep 24, 2016
Landed in 43e1ca8 |
jasnell pushed a commit that referenced this pull request Sep 29, 2016
There are multiple tests that use the same boilerplate to test that warnings are correctly emitted. This adds a new common function to do that and changes the tests to use it. PR-URL: #8662 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
geek pushed a commit to geek/node that referenced this pull request Sep 30, 2016
There are multiple tests that use the same boilerplate to test that warnings are correctly emitted. This adds a new common function to do that and changes the tests to use it. PR-URL: nodejs#8662 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
There are multiple tests that use the same boilerplate to test that warnings are correctly emitted. This adds a new common function to do that and changes the tests to use it. PR-URL: #8662 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Conflicts: test/parallel/test-buffer-deprecated.js test/parallel/test-repl-deprecated.js
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
There are multiple tests that use the same boilerplate to test that warnings are correctly emitted. This adds a new common function to do that and changes the tests to use it. PR-URL: #8662 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
There are multiple tests that use the same boilerplate to test that warnings are correctly emitted. This adds a new common function to do that and changes the tests to use it. PR-URL: #8662 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
There are multiple tests that use the same boilerplate to test that warnings are correctly emitted. This adds a new common function to do that and changes the tests to use it. PR-URL: #8662 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Jul 1, 2023
This was referenced Jul 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
There are multiple tests that use the same boilerplate to test that
deprecation warnings are correctly emmited. This adds a new common
function to do that and changes the tests to use it.
/cc @nodejs/testing @addaleax