deps: fix icu-shrinker to handle ICU 58#8674
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ICU’s license file changed from `license.html` to `LICENSE`. Fix `shrink-icu-src.py` (which is manually run) to accept either file. Related to nodejs#7844 which is the 58 bump.
srl295 added tools 
| if'license.html'inign: | ||
| ign.remove('license.html') | ||
| if'LICENSE'inign: | ||
| ign.remove('LICENSE') |
Member
There was a problem hiding this comment.
out of my head but perhaps if any(item in ign for item in('LICENSE', 'license.html'))
MemberAuthor
There was a problem hiding this comment.
Thanks. I'm going to change the logic a bit here. We want to keep 'LICENSE' || 'license.html' in that order.
| ign=ign+ ['unidata','curr','zone','unit','lang','region','misc','sprep'] | ||
| #elif subdir == 'source/data': | ||
| # ign = ign + ['unidata','curr','zone','unit','lang','region','misc','sprep'] | ||
| # else: |
MemberAuthor
There was a problem hiding this comment.
yes, will remove. and the following comments.
rvaggforce-pushed the master branch 2 times, most recently from c133999 to 83c7a88Compare
MemberAuthor
srl295 commented Oct 25, 2016
@jbergstroem I'm not sure where I ended up with this… but I'll revisit your comments now that #7844 is now in progress. |
MemberAuthor
srl295 commented Oct 25, 2016
@jbergstroem I'm going to fold this into #9234 and close this PR. |
srl295 added a commit to srl295/node that referenced this pull request Oct 31, 2016
* bump to ICU 58.1 - update URL / hash * does not attempt to reduce size - yet * patch to work around http://bugs.icu-project.org/trac/ticket/12822 ( compile issue on Windows) * Fix ICU shrinker to delete old license.html file (update to nodejs#8674 ) Fixes: nodejs#7844 PR-URL: nodejs#9234 Reviewed-By: James M Snell <[email protected]>
srl295 added a commit that referenced this pull request Oct 31, 2016
* bump to ICU 58.1 - update URL / hash * does not attempt to reduce size - yet * patch to work around http://bugs.icu-project.org/trac/ticket/12822 ( compile issue on Windows) * Fix ICU shrinker to delete old license.html file (update to #8674 ) Fixes: #7844 PR-URL: #9234 Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
* bump to ICU 58.1 - update URL / hash * does not attempt to reduce size - yet * patch to work around http://bugs.icu-project.org/trac/ticket/12822 ( compile issue on Windows) * Fix ICU shrinker to delete old license.html file (update to #8674 ) Fixes: #7844 PR-URL: #9234 Reviewed-By: James M Snell <[email protected]>
srl295 added a commit to srl295/node that referenced this pull request Jan 18, 2017
* bump to ICU 58.1 - update URL / hash * does not attempt to reduce size - yet * patch to work around http://bugs.icu-project.org/trac/ticket/12822 ( compile issue on Windows) * Fix ICU shrinker to delete old license.html file (update to nodejs#8674 ) Fixes: nodejs#7844 PR-URL: nodejs#9234 Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 20, 2017
* bump to ICU 58.1 - update URL / hash * does not attempt to reduce size - yet * patch to work around http://bugs.icu-project.org/trac/ticket/12822 ( compile issue on Windows) * Fix ICU shrinker to delete old license.html file (update to #8674 ) Fixes: #7844 PR-URL: #9234 Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
* bump to ICU 58.1 - update URL / hash * does not attempt to reduce size - yet * patch to work around http://bugs.icu-project.org/trac/ticket/12822 ( compile issue on Windows) * Fix ICU shrinker to delete old license.html file (update to #8674 ) Fixes: #7844 PR-URL: #9234 Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
* bump to ICU 58.1 - update URL / hash * does not attempt to reduce size - yet * patch to work around http://bugs.icu-project.org/trac/ticket/12822 ( compile issue on Windows) * Fix ICU shrinker to delete old license.html file (update to #8674 ) Fixes: #7844 PR-URL: #9234 Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected core subsystem(s)
Description of change
ICU’s license file changed from
license.htmltoLICENSE.Fix
shrink-icu-src.py(which is manually run) to accept either file.Related to #7844 which is the 58 bump.