v4.x backport: url: fix inconsistent port in url.resolveObject#8872
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit fixes bug where url.resolveObject returns conflicting host and port values. Fixes: nodejs#8213 PR-URL: nodejs#8214 Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot added url MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
This commit fixes bug where url.resolveObject returns conflicting host and port values. Fixes: #8213 Ref: #8872 PR-URL: #8214 Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Sep 30, 2016
landed in 2362504 |
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
This commit fixes bug where url.resolveObject returns conflicting host and port values. Fixes: #8213 Ref: #8872 PR-URL: #8214 Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
This commit fixes bug where url.resolveObject returns conflicting host and port values. Fixes: #8213 Ref: #8872 PR-URL: #8214 Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
This commit fixes bug where url.resolveObject returns conflicting host and port values. Fixes: #8213 Ref: #8872 PR-URL: #8214 Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v4.x backport of #8214
/cc @thealphanerd