build: don't build icu with -fno-rtti#8886
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: nodejs#8867
bnoordhuis added build 
fhinkel approved these changes Oct 3, 2016
Member
fhinkel commented Oct 3, 2016
Landed in c1be609. |
fhinkel pushed a commit that referenced this pull request Oct 3, 2016
ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: #8867 PR-URL: #8886 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 6, 2016
ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: #8867 PR-URL: #8886 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Contributor
MylesBorins commented Oct 6, 2016
@bnoordhuis should this be backported or is it specific to v6? |
MemberAuthor
bnoordhuis commented Oct 7, 2016
Looking at tools/icu/icu-generic.gyp in the v4.x-staging branch, this would need to be back-ported, yes. |
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: #8867 PR-URL: #8886 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: #8867 PR-URL: #8886 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICU should be compiled with -frtti (and it sets that flag in its gyp
file) but it was also inheriting the -fno-rtti flag from common.gypi,
breaking the build on some systems.
Fixes: #8867