deps: v8 - cherry-pick missing v8 floating patch#8907
Uh oh!
There was an error while loading. Please reload this page.
Conversation
2d524bc Original commit message: deps: limit regress/regress-crbug-514081 v8 test regress/regress-crbug-514081 allocates a 2G block of memory and if there are multiple variants running at the same time this can lead to crashes, OOM kills or the OS failing to allocate memory. This patch limits us to running a single variant of the test Fixes: nodejs#6340 PR-URL: nodejs#6678 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
nodejs-github-bot added the v8 engine 
targos commented Oct 3, 2016
LGTM. Sorry for missing it during the V8 update 😕 |
mhdawson commented Oct 3, 2016
Earlier v8 run to validate: https://ci.nodejs.org/job/node-test-commit-v8-linux/347/ |
mhdawson commented Oct 3, 2016
MylesBorins commented Oct 3, 2016
can we make a document that lists the V8 branches we are maintaining and /cc @ofrobots On Mon, Oct 3, 2016, 11:32 AM Michael Dawson [email protected]
|
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
LGTM but can you spell my surname correctly, please? :-)
Also, I'd drop the redundant "v8 -" from the status line.
mhdawson commented Oct 3, 2016
CI run looked ok other than Windows failures that were present before/after and not related to this change so I think we are good to go. @bnoordhuis will address your comments while landing. |
mhdawson commented Oct 4, 2016
Assume this is non-controversial so will plan to land later today. |
2d524bc Original commit message: deps: limit regress/regress-crbug-514081 v8 test regress/regress-crbug-514081 allocates a 2G block of memory and if there are multiple variants running at the same time this can lead to crashes, OOM kills or the OS failing to allocate memory. This patch limits us to running a single variant of the test Fixes: #6340 PR-URL: #6678 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> PR-URL: #8907Fixes: #8750 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
mhdawson commented Oct 5, 2016
Landed as 4b3e4d5 |
2d524bc Original commit message: deps: limit regress/regress-crbug-514081 v8 test regress/regress-crbug-514081 allocates a 2G block of memory and if there are multiple variants running at the same time this can lead to crashes, OOM kills or the OS failing to allocate memory. This patch limits us to running a single variant of the test Fixes: #6340 PR-URL: #6678 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> PR-URL: #8907Fixes: #8750 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Fishrock123 commented Oct 10, 2016
empty patch on v6 |
6 participants
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
v8
Description of change
cherry-pick missing v8 floating patch
2d524bc
Fixes: #8750
Original commit message:
deps: limit regress/regress-crbug-514081 v8 test
regress/regress-crbug-514081 allocates a 2G block of memory
and if there are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory. This patch
limits us to running a single variant of the test
Fixes: #6340
PR-URL: #6678
Reviewed-By: Ben Noorhduis [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Fedor Indutny [email protected]