net: fix ambiguity in EOF handling#9066
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
mcollina commented Oct 12, 2016
Nice one. I imagine there is very little chance to write a unit test for this, right? if not, LGTM. |
MemberAuthor
indutny commented Oct 12, 2016
@mcollina I actually just got an idea on how to do this, but wanted to gather some preliminary feedback first. |
MemberAuthor
indutny commented Oct 12, 2016
Added test. |
Member
Trott commented Oct 12, 2016
@indutny Test not showing up here... (Forgot to push maybe? Or need to force-push maybe?) |
`end` MUST always be emitted **before** `close`. However, if a handle will invoke `uv_close_cb` immediately, or in the same JS tick - `close` may be emitted first.
indutnyforce-pushed the fix/ambiguity-in-net branch from 9920f17 to 6e38e76CompareMemberAuthor
indutny commented Oct 12, 2016
@Trott sorry, just pushed it! |
MemberAuthor
indutny commented Oct 12, 2016
Member
Trott commented Oct 12, 2016
Stress test to make sure there's no unexpected flakiness hidden in the test somewhere: https://ci.nodejs.org/job/node-stress-single-test/994/ (Failures on the two win2008* jobs can be ignored, I think.) |
Member
Trott commented Oct 12, 2016
LGTM if no CI oddities arise. |
| process.on('exit', () =>{ | ||
| assert.deepStrictEqual(events, [ 'end', 'close' ]); | ||
| }); |
Member
There was a problem hiding this comment.
Would something like this work?
s.on('end',common.mustCall(()=>{s.on('close',common.mustCall(()=>{}));}));... so you can get rid of events and the exit listener.
MemberAuthor
There was a problem hiding this comment.
On one hand - yes, on the other - if this test will ever error, the error message will be more informative.
Member
mcollina commented Oct 13, 2016
LGTM |
mcollina approved these changes Oct 13, 2016
cjihrig approved these changes Oct 13, 2016
MemberAuthor
indutny commented Oct 14, 2016
Landed in 31196ea, thank you! |
indutny added a commit that referenced this pull request Oct 14, 2016
`end` MUST always be emitted **before** `close`. However, if a handle will invoke `uv_close_cb` immediately, or in the same JS tick - `close` may be emitted first. PR-URL: #9066 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 14, 2016
`end` MUST always be emitted **before** `close`. However, if a handle will invoke `uv_close_cb` immediately, or in the same JS tick - `close` may be emitted first. PR-URL: #9066 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
Contributor
MylesBorins commented Nov 11, 2016
@indutny this lands cleanly on v4 and v6. Is this something we should consider backporting? |
MemberAuthor
indutny commented Nov 11, 2016
@thealphanerd yep |
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
`end` MUST always be emitted **before** `close`. However, if a handle will invoke `uv_close_cb` immediately, or in the same JS tick - `close` may be emitted first. PR-URL: #9066 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
`end` MUST always be emitted **before** `close`. However, if a handle will invoke `uv_close_cb` immediately, or in the same JS tick - `close` may be emitted first. PR-URL: #9066 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
This was referenced Nov 30, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
net
Description of change
endMUST always be emitted beforeclose. However, if a handlewill invoke
uv_close_cbimmediately, or in the same JS tick -closemay be emitted first.
cc @nodejs/collaborators