Fix test debug agent#9119
Closed
Fix test debug agent #9119
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cjihrig reviewed Oct 16, 2016
test/parallel/test-debug-agent.js Outdated
| assert.throws(()=>{require('_debug_agent').start();}, | ||
| assert.AssertionError); | ||
| assert.throws( | ||
| ()=>{debug.start();}, |
Contributor
There was a problem hiding this comment.
Can you use consistent spacing around the curly braces.
cjihrig reviewed Oct 16, 2016
test/parallel/test-debug-agent.js Outdated
| assert.AssertionError); | ||
| assert.throws( | ||
| ()=>{debug.start();}, | ||
| function(err){ |
Contributor
There was a problem hiding this comment.
The indentation looks off here.
Member
Trott commented Oct 17, 2016
LGTM with spacing nits fixed |
lpinca reviewed Oct 17, 2016
| ()=>{debug.start();}, | ||
| function(err){ | ||
| return(errinstanceofassert.AssertionError&& | ||
| err.message==='Debugger agent running without bindings!'); |
Member
Trott commented Oct 17, 2016
rvaggforce-pushed the master branch 2 times, most recently from c133999 to 83c7a88Compare
jasnell pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #9119 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
jasnell commented Oct 18, 2016
Landed in 4e1d6d0 |
Member
jasnell commented Oct 18, 2016
Fixed the remaining indenting nit on landing. |
jasnell pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #9119 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 19, 2016
PR-URL: #9119 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2016
PR-URL: #9119 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2016
PR-URL: #9119 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected core subsystem(s)
test
Description of change
Cheching if the throwed exception is assert.AssertError