Skip to content

Conversation

@joshgav
Copy link
Contributor

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

as in title

/cc @nodejs/ctc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 19, 2016
Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


@trott: Is this a semver-major change?

@jasnell: No, especially cause this is an experimental feature.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: No, especially cause -> No because

* Julien Gilli @misterdjules (CTC)
* nothing too significant
* Mikeal Rogers @mikeal (observer/Node.js Foundation)
* Putting together bugeting stuff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

budgeting?

* HTTP/2 implementation
* PRs
* Josh Gavant @joshgav (observer/Microsoft)
* PR’s to improve user experience with new debugger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: PRs

* mostly PR reviews
* Trevor Norris @trevnorris (CTC)
* Worked with Matt Loring, proposed promise hooks api is
sufficient combined with debugger API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sentence could be improved.

jasnell pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #9193 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

Landed in 0c61b4d

@jasnelljasnell closed this Oct 26, 2016
@joshgavjoshgav deleted the ctc-2016-10-19 branch October 27, 2016 20:08
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
PR-URL: #9193 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
@evanlucasevanlucas mentioned this pull request Nov 3, 2016
MylesBorins pushed a commit that referenced this pull request Nov 15, 2016
PR-URL: #9193 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2016
PR-URL: #9193 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Nov 22, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@joshgav@jasnell@thefourtheye@Trott@mhdawson@MylesBorins@nodejs-github-bot