test: make test-crypto-timing-safe-equal-benchmarks more reliable#9241
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cjihrig approved these changes Oct 22, 2016
Contributor
not-an-aardvark commented Oct 22, 2016
CI: https://ci.nodejs.org/job/node-test-commit/5731/ LGTM if this makes the test less flaky |
Contributor
not-an-aardvark commented Oct 22, 2016
Oh wait, I suppose this test won't actually get run in CI now that it's part of |
Member
jasnell commented Oct 22, 2016
Unfortunate that this won't be run regularly. We'll just need to be vigilant about running the test manually whenever there's a change that could impact this. |
jasnell approved these changes Oct 22, 2016
Move sequential/test-crypto-timing-safe-equal-benchmarks to test/pummel because it fails for me locally quite frequently and because it takes about five or six seconds to complete, which is too long for a test in test/sequential. Fixes: nodejs#8744 PR-URL: nodejs#9241 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: not-an-aardvark <[email protected]>
Increase the number of iterations from 1e4 to 1e5. Makes the test pass for me locally when previously it would fail 9 out of 10 times because the running time was not enough to smooth away the outliers. Fixes: nodejs#8744 PR-URL: nodejs#9241 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: not-an-aardvark <[email protected]>
evanlucas pushed a commit that referenced this pull request Nov 2, 2016
Move sequential/test-crypto-timing-safe-equal-benchmarks to test/pummel because it fails for me locally quite frequently and because it takes about five or six seconds to complete, which is too long for a test in test/sequential. Fixes: #8744 PR-URL: #9241 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: not-an-aardvark <[email protected]>
evanlucas pushed a commit that referenced this pull request Nov 2, 2016
Increase the number of iterations from 1e4 to 1e5. Makes the test pass for me locally when previously it would fail 9 out of 10 times because the running time was not enough to smooth away the outliers. Fixes: #8744 PR-URL: #9241 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: not-an-aardvark <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2016
Move sequential/test-crypto-timing-safe-equal-benchmarks to test/pummel because it fails for me locally quite frequently and because it takes about five or six seconds to complete, which is too long for a test in test/sequential. Fixes: #8744 PR-URL: #9241 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: not-an-aardvark <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2016
Increase the number of iterations from 1e4 to 1e5. Makes the test pass for me locally when previously it would fail 9 out of 10 times because the running time was not enough to smooth away the outliers. Fixes: #8744 PR-URL: #9241 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: not-an-aardvark <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
Move sequential/test-crypto-timing-safe-equal-benchmarks to test/pummel because it fails for me locally quite frequently and because it takes about five or six seconds to complete, which is too long for a test in test/sequential. Fixes: #8744 PR-URL: #9241 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: not-an-aardvark <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
Increase the number of iterations from 1e4 to 1e5. Makes the test pass for me locally when previously it would fail 9 out of 10 times because the running time was not enough to smooth away the outliers. Fixes: #8744 PR-URL: #9241 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: not-an-aardvark <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R=@not-an-aardvark?