src: remove unused function#9243
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mscdex added c++ 
nodejs-github-bot added the c++ 
Member
bnoordhuis commented Oct 23, 2016
See #9220 for an alternative take. Whether it's unused or not depends on whether the C++ standard library exports a |
ContributorAuthor
@bnoordhuis I can't seem to find what actually uses |
Member
bnoordhuis commented Oct 23, 2016
Oh, it might be vestigial from the initial version of #8919. If it's not actually in use (and the CI seems to confirm that), then it LGTM. |
jasnell approved these changes Oct 23, 2016
jasnell pushed a commit that referenced this pull request Oct 25, 2016
PR-URL: #9243 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Member
jasnell commented Oct 25, 2016
Landed in ed41d8d |
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
PR-URL: #9243 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
PR-URL: #9243 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
PR-URL: #9243 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
PR-URL: #9243 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
Remove an unused function.
CI: https://ci.nodejs.org/job/node-test-pull-request/4627/
/cc @nodejs/v8-inspector