src: fix use of uninitialized variable#9281
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
MemberAuthor
jasnell commented Oct 25, 2016
MemberAuthor
jasnell commented Oct 28, 2016
ping @addaleax@bnoordhuis |
bnoordhuis approved these changes Oct 28, 2016
Member
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
LGTM with nit. Does valgrind -q complain without this patch? If no, consider adding a regression test.
src/node_i18n.cc Outdated
Member
There was a problem hiding this comment.
You have an extraneous paren in the string.
Variable was uninitialized in 72547fe Initialize the variable and add a static_check
jasnellforce-pushed the check-uninitialized branch from f8dfec9 to e0bad1eComparejasnell added a commit that referenced this pull request Oct 28, 2016
Variable was uninitialized in 72547fe Initialize the variable and add a static_check PR-URL: #9281 Reviewed-By: Ben Noordhuis <[email protected]>
MemberAuthor
jasnell commented Oct 28, 2016
Landed in 2bd850b |
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
Variable was uninitialized in 72547fe Initialize the variable and add a static_check PR-URL: #9281 Reviewed-By: Ben Noordhuis <[email protected]>
Contributor
MylesBorins commented Nov 22, 2016
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
src
Description of change
Alternative to #9280 ...
The proposed fix in 9280 breaks the calculation algorithm.
Variable was uninitialized in 72547fe Initialize the variable and add a static_check
/cc @bnoordhuis@addaleax