test: use 'strictEqual' instead of 'equal'#9297
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Trott commented Oct 26, 2016
Can the |
mscdex added async_wrap async_hooks 
gerges-beshay commented Oct 26, 2016
Oh, I missed that. I made the change and tested it, and it passed. |
gerges-beshay commented Oct 26, 2016
I noticed that some of the checks reported on GitHub as "not successful". Does the tests currently have some flaky issues? If so, is there a ticket already reporting more details on this to look into? |
Trott commented Oct 26, 2016
There are a lot of test/CI issues right now, unfortunately. Failures are very likely to be unrelated to these changes. |
gerges-beshay commented Oct 26, 2016
So what is the current process in these cases? I believe having deterministic tests is vital. I'll work on that as I get more familiar with the code base and tests. |
* use 'strictEqual' instead of 'equal' * use '!==' instead of '!=' PR-URL: nodejs#9297 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Trott commented Oct 28, 2016
Landed in 758ca8d |
Trott commented Oct 28, 2016
Collaborators know what known-issues to ignore (hopefully). In the meantime, people are working to fix stuff. If you want to help with that sort of thing specifically, places to look include: |
* use 'strictEqual' instead of 'equal' * use '!==' instead of '!=' PR-URL: #9297 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
* use 'strictEqual' instead of 'equal' * use '!==' instead of '!=' PR-URL: #9297 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
* use 'strictEqual' instead of 'equal' * use '!==' instead of '!=' PR-URL: #9297 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
7 participants
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesDescription of change
Use 'strictEqual' instead of 'equal' in 'test-async-wrap-check-providers'.