test: fix freebsd10-64 CI failures#9317
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cjihrig approved these changes Oct 27, 2016
MemberAuthor
Trott commented Oct 27, 2016
Member
The changes LGTM. |
MemberAuthor
Trott commented Oct 27, 2016
GREEN! CI IS GREEN! |
addaleax approved these changes Oct 27, 2016
gibfahn approved these changes Oct 27, 2016
misterdjules approved these changes Oct 27, 2016
MemberAuthor
Trott commented Oct 28, 2016
Running CI on this over and over to confirm there aren't other timer issues lurking in other tests, I found another timer to be removed in |
Member
santigimeno commented Oct 28, 2016
Still LGTM |
MemberAuthor
Trott commented Oct 28, 2016
CI with the additional change: https://ci.nodejs.org/job/node-test-pull-request/4726/ |
Remove unneeded timers from some tests and move others from parallel testing to sequential testing. This is to resolve test failures on freebsd10-64 on CI. The failures are all due to timers firing later than expected. Timers firing later than they are set for can happen on resource-constrained hosts and is not a bug. In general, it may be wise to put tests that depend on timing into sequential testing rather than parallel testing, as the timing can be affected by other simultaneously-running test processes. Fixes: nodejs#8041Fixes: nodejs#9227
MemberAuthor
Trott commented Oct 29, 2016
Freebsd failure on last ci was Jenkins disconnect related. Had to rebase and force push to resolve a merge conflict with master anyway, so let's run CI again! |
MemberAuthor
Trott commented Oct 29, 2016
Additional failing test on FreeBSD is unrelated. Will open a separate PR for it. |
Trott added a commit to Trott/io.js that referenced this pull request Oct 29, 2016
Remove unneeded timers from some tests and move others from parallel testing to sequential testing. This is to resolve test failures on freebsd10-64 on CI. The failures are all due to timers firing later than expected. Timers firing later than they are set for can happen on resource-constrained hosts and is not a bug. In general, it may be wise to put tests that depend on timing into sequential testing rather than parallel testing, as the timing can be affected by other simultaneously-running test processes. Fixes: nodejs#8041Fixes: nodejs#9227 PR-URL: nodejs#9317 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Johan Bergstrom <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MemberAuthor
Trott commented Oct 29, 2016
Landed in 6ef636c |
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
Remove unneeded timers from some tests and move others from parallel testing to sequential testing. This is to resolve test failures on freebsd10-64 on CI. The failures are all due to timers firing later than expected. Timers firing later than they are set for can happen on resource-constrained hosts and is not a bug. In general, it may be wise to put tests that depend on timing into sequential testing rather than parallel testing, as the timing can be affected by other simultaneously-running test processes. Fixes: #8041Fixes: #9227 PR-URL: #9317 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Johan Bergstrom <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
Remove unneeded timers from some tests and move others from parallel testing to sequential testing. This is to resolve test failures on freebsd10-64 on CI. The failures are all due to timers firing later than expected. Timers firing later than they are set for can happen on resource-constrained hosts and is not a bug. In general, it may be wise to put tests that depend on timing into sequential testing rather than parallel testing, as the timing can be affected by other simultaneously-running test processes. Fixes: #8041Fixes: #9227 PR-URL: #9317 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Johan Bergstrom <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Merged
aqrln added a commit to aqrln/node that referenced this pull request Jul 19, 2017
Move test-http-server-keep-alive-timeout-slow-server and test-http-server-keep-alive-timeout-slow-client-headers from parallel to sequential to (hopefully) resolve test flakiness on freebsd10-64. Refs: nodejs#14033 Refs: nodejs#9317
2 tasks
aqrln added a commit that referenced this pull request Jul 22, 2017
Move test-http-server-keep-alive-timeout-slow-server and test-http-server-keep-alive-timeout-slow-client-headers from parallel to sequential to resolve test flakiness on freebsd10-64. Fixes: #14033 Refs: #9317 PR-URL: #14377 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 22, 2017
Move test-http-server-keep-alive-timeout-slow-server and test-http-server-keep-alive-timeout-slow-client-headers from parallel to sequential to resolve test flakiness on freebsd10-64. Fixes: #14033 Refs: #9317 PR-URL: #14377 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 24, 2017
Move test-http-server-keep-alive-timeout-slow-server and test-http-server-keep-alive-timeout-slow-client-headers from parallel to sequential to resolve test flakiness on freebsd10-64. Fixes: #14033 Refs: #9317 PR-URL: #14377 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Remove unneeded timers from some tests and move others from parallel
testing to sequential testing.
This is to resolve test failures on freebsd10-64 on CI. The failures
are all due to timers firing later than expected. Timers firing later
than they are set for can happen on resource-constrained hosts and is
not a bug.
In general, it may be wise to put tests that depend on timing into
sequential testing rather than parallel testing, as the timing can
be affected by other simultaneously-running test processes.
I ran this change set (with one fewer files moved to sequential, so not quite this change set) through CI six times and there were no failures on freebsd10-64. I did the same with current master and two of the six runs failed with tests involved in this PR. (I'll probably do at least that many again now that it's a PR.)
/cc @nodejs/testing @nodejs/platform-freebsd @misterdjules