Skip to content

Conversation

@pvsousalima
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

repl

Description of change

repl: name anonymous functions in repl module

name anonymous functions in repl module
the changes are related to Ref: #8913
regarding the naming of just the inline anonymous
functions that are not assigned to a variable

name anonymous functions in repl module the changes are related to Ref: #8913 regarding the naming of just the inline anonymous functions that are not assigned to a variable
removing long function names to match the 80 character limitation
@nodejs-github-botnodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Oct 29, 2016
@pvsousalimapvsousalima changed the title Name repl anonymousname repl anonymousOct 29, 2016
@pvsousalimapvsousalima changed the title name repl anonymousname repl anonymous functionsOct 29, 2016
@Trott
Copy link
Member

LGTM if CI is ✅

Copy link
Member

@jasnelljasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silverwind
Copy link
Contributor

Thanks! Landed in e658f5b.

silverwind pushed a commit that referenced this pull request Nov 1, 2016
the changes are related to #8913 regarding the naming of just the inline anonymous functions that are not assigned to a variable PR-URL: #9356 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
the changes are related to #8913 regarding the naming of just the inline anonymous functions that are not assigned to a variable PR-URL: #9356 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
@evanlucasevanlucas mentioned this pull request Nov 3, 2016
@MylesBorinsMylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label May 8, 2017
@MylesBorinsMylesBorins added dont-land-on-v6.x and removed baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Nov 14, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

replIssues and PRs related to the REPL subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@pvsousalima@Trott@silverwind@jasnell@MylesBorins@nodejs-github-bot