build: start comments at beginning of line#9375
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
As the comments are indented in Makefile, they are actually echoed on the screen. This patch makes sure that the comments actually start at the beginning of the line, and so not echoed and ignored.
nodejs-github-bot added the build 
ContributorAuthor
thefourtheye commented Oct 31, 2016
Before After |
cjihrig approved these changes Oct 31, 2016
silverwind approved these changes Oct 31, 2016
Contributor
silverwind left a comment
silverwind left a comment There was a problem hiding this comment.
LGTM, didn't know this was an issue in make
Member
jbergstroem commented Oct 31, 2016
@silverwind: makefile is whitespace-aware. Try using ifeq() or other functions with a prefixed tab/space :) |
gibfahn approved these changes Oct 31, 2016
princejwesley approved these changes Nov 1, 2016
benjamingr approved these changes Nov 2, 2016
jasnell approved these changes Nov 2, 2016
ContributorAuthor
thefourtheye commented Nov 5, 2016
Landed in f9504a5 |
thefourtheye added a commit that referenced this pull request Nov 5, 2016
As the comments are indented in Makefile, they are actually echoed on the screen. This patch makes sure that the comments actually start at the beginning of the line, and so not echoed and ignored. PR-URL: #9375 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
As the comments are indented in Makefile, they are actually echoed on the screen. This patch makes sure that the comments actually start at the beginning of the line, and so not echoed and ignored. PR-URL: #9375 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Nov 22, 2016
@thefourtheye do you want to backport this? |
ContributorAuthor
@thealphanerd Yes. Isn't this landing cleanly? |
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
As the comments are indented in Makefile, they are actually echoed on the screen. This patch makes sure that the comments actually start at the beginning of the line, and so not echoed and ignored. PR-URL: #9375 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Nov 22, 2016
it does on v6.x but not v4.x |
Merged
3 tasks
ContributorAuthor
thefourtheye commented Dec 20, 2016
@thealphanerd I backported this in #10364 |
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
As the comments are indented in Makefile, they are actually echoed on the screen. This patch makes sure that the comments actually start at the beginning of the line, and so not echoed and ignored. PR-URL: #9375 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
As the comments are indented in Makefile, they are actually echoed on the screen. This patch makes sure that the comments actually start at the beginning of the line, and so not echoed and ignored. PR-URL: #9375 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
As the comments are indented in Makefile, they are actually echoed on the screen. This patch makes sure that the comments actually start at the beginning of the line, and so not echoed and ignored. PR-URL: nodejs/node#9375 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
build
Description of change
As the comments are indented in Makefile, they are actually echoed
on the screen. This patch makes sure that the comments actually start
at the beginning of the line, and so not echoed and ignored.
--
cc @nodejs/build cc @nodejs/collaborators