vm: name anonymous functions#9388
Uh oh!
There was an error while loading. Please reload this page.
Conversation
lib/vm.js Outdated
| Script.prototype.runInThisContext=function(options){ | ||
| if(options&&options.breakOnSigint){ | ||
| returnsigintHandlersWrap(()=>{ | ||
| constsigintHandler=()=>{ |
There was a problem hiding this comment.
If line length is below 80 chars I think it is ok to put the whole function expression on one line.
There was a problem hiding this comment.
I am a bit 😕 about the name here… this function does not handle any kind of signal; it’s the exact opposite, the function is run undisturbed by SIGINTs. (The comment/code for sigintHandlersWrap has a bit more information.) So maybe you could call it realRunInThisContext or runScriptUninterruped or something like that?
There was a problem hiding this comment.
where is the doc you are referring to , i want to understand this a little better
benjamingr commented Nov 6, 2016
CI: https://ci.nodejs.org/job/node-test-commit/5938/console Going to land if no one objects. |
Name anonymous arrow function in vm module to improve readability PR-URL: #9388 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Ref: #8913
benjamingr commented Nov 6, 2016
Landed in 5079763 Thanks! |
Name anonymous arrow function in vm module to improve readability PR-URL: #9388 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Ref: #8913
MylesBorins added the baking-for-lts 
gibfahn commented Jun 17, 2017
#10816 should land at the same time as this. |
MylesBorins added dont-land-on-v6.x and removed baking-for-lts 8 participants
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
vm
Description of change
named arrow function handlers :)
Ref: #8913