Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Nov 2, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The doc says that the CTC moderator is responsible for taking minutes
and that the minutes for each agenda item should be a separate pull
request.

This change updates the doc to say that the moderator is responsible for
making sure that notes are taken, but not necessarily taking the notes
themselves. Furthermore, it removes the separate-pull-request
requirement as that is not what happens in practice.

@nodejs/ctc

@TrottTrott added doc Issues and PRs related to the documentations. ctc-review labels Nov 2, 2016
@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 2, 2016
@joshgav
Copy link
Contributor

LGTM, it's hard to run a meeting and take notes at the same time.

I didn't interpret the original as requiring a separate PR for each agenda item, but no matter with this change.

@Trott
Copy link
MemberAuthor

Trott commented Nov 4, 2016

I didn't interpret the original as requiring a separate PR

You're right. It probably was not intended that way.

GOVERNANCE.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should insuring be ensuring instead ?

Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

The doc says that the CTC moderator is responsible for taking minutes and that the minutes for each agenda item should be a separate pull request. This change updates the doc to say that the moderator is responsible for making sure that notes are taken, but not necessarily taking the notes themselves. Furthermore, it removes the separate-pull-request requirement as that is not what happens in practice.
Trott added a commit to Trott/io.js that referenced this pull request Nov 6, 2016
The doc says that the CTC moderator is responsible for taking minutes. This change updates the doc to say that the moderator is responsible for making sure that notes are taken, but not necessarily taking the notes themselves. PR-URL: nodejs#9425 Reviewed-By: Josh Gavant <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@Trott
Copy link
MemberAuthor

Trott commented Nov 6, 2016

Landed in 7dd3fb8

@TrottTrott closed this Nov 6, 2016
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
The doc says that the CTC moderator is responsible for taking minutes. This change updates the doc to say that the moderator is responsible for making sure that notes are taken, but not necessarily taking the notes themselves. PR-URL: #9425 Reviewed-By: Josh Gavant <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@evanlucasevanlucas mentioned this pull request Nov 7, 2016
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
The doc says that the CTC moderator is responsible for taking minutes. This change updates the doc to say that the moderator is responsible for making sure that notes are taken, but not necessarily taking the notes themselves. PR-URL: #9425 Reviewed-By: Josh Gavant <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
The doc says that the CTC moderator is responsible for taking minutes. This change updates the doc to say that the moderator is responsible for making sure that notes are taken, but not necessarily taking the notes themselves. PR-URL: #9425 Reviewed-By: Josh Gavant <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This was referenced Nov 22, 2016
@TrottTrott deleted the minutes branch January 13, 2022 22:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@joshgav@evanlucas@mhdawson@MylesBorins@nodejs-github-bot