Skip to content

build: add MAKEFLAGS="-j1" to node-gyp#9450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danbev wants to merge 3 commits into from
Closed

build: add MAKEFLAGS="-j1" to node-gyp #9450

danbev wants to merge 3 commits into from

Conversation

@danbev
Copy link
Contributor

@danbevdanbev commented Nov 3, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

Currently, when building the addons the following warning is displayed:

make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule.

Adding the MAKEFLAGS="-j1" to avoid the warning.

Also updated the log message to say that it is building the addon and
not running the test as I think that is more accurate.

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 3, 2016
@danbev
Copy link
ContributorAuthor

danbev commented Nov 3, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4773/

addaleax
addaleax approved these changes Nov 3, 2016
View reviewed changes
Copy link
Member

@addaleaxaddaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/cc @bnoordhuis

bnoordhuis
bnoordhuis requested changes Nov 3, 2016
View reviewed changes
Copy link
Member

@bnoordhuisbnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first line of the commit log is slightly too long.

Makefile Outdated
Copy link
Member

@bnoordhuisbnoordhuisNov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env MAKEFLAGS="-j1" ...? I believe what you have now is a bash-ism, not a posix-ism.

Copy link
ContributorAuthor

@danbevdanbevNov 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah indeed, I'll correct this. Thanks

@danbevdanbevforce-pushed the supress-addons-build-warn branch from ec33fca to 772be0fCompareNovember 4, 2016 06:23
@danbevdanbev changed the title build: add MAKEFLAGS="-j1" to node-gyp to avoid warnbuild: add MAKEFLAGS="-j1" to node-gypNov 4, 2016
@danbev
Copy link
ContributorAuthor

danbev commented Nov 4, 2016

The first line of the commit log is slightly too long.

Sorry, for some reason I though 52 characters was the limit but of course it is 50 (the 2 is for in other lines and then it's 72). Thanks

@danbev
Copy link
ContributorAuthor

danbev commented Nov 4, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4780/

thefourtheye
thefourtheye approved these changes Nov 4, 2016
View reviewed changes
Makefile Outdated
Copy link
Contributor

@thefourtheyethefourtheyeNov 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about silencing this in the other commit and it landed before I got a chance to get back to it. Can we do it in this? I am okay without that as well.

Copy link
ContributorAuthor

@danbevdanbevNov 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do it in this?

Absolutely, no problems.

@danbev
build: add MAKEFLAGS="-j1" to node-gyp
604a01f
Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate.
@danbev
use the shell env command to set MAKEFLAGS
327cd52
@danbev
supress echoing of for loop
fb4eafd
@danbevdanbevforce-pushed the supress-addons-build-warn branch from ce36c39 to fb4eafdCompareNovember 5, 2016 20:14
@danbev
Copy link
ContributorAuthor

danbev commented Nov 5, 2016

Rebased and new CI: https://ci.nodejs.org/job/node-test-pull-request/4789/

@danbev
Copy link
ContributorAuthor

danbev commented Nov 6, 2016

CI failure does not seem related to this change:

not ok 236 parallel/test-debugger-util-regression # # assert.js:85 # throw new assert.AssertionError({# ^ # AssertionError: the program should not hang # at Object.exports.fail (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/common.js:443:10) # at Timeout.fail [as _onTimeout] (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-debugger-util-regression.js:23:10) # at ontimeout (timers.js:365:14) # at tryOnTimeout (timers.js:237:5) # at Timer.listOnTimeout (timers.js:207:5)

If there are no objections I'll merge this tomorrow.

danbev added a commit to danbev/node that referenced this pull request Nov 7, 2016
@danbev
build: add MAKEFLAGS="-j1" to node-gyp
a504516
Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: nodejs#9450 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@danbev
Copy link
ContributorAuthor

danbev commented Nov 7, 2016

Landed in: a504516

@danbevdanbev closed this Nov 7, 2016
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
@danbev@evanlucas
build: add MAKEFLAGS="-j1" to node-gyp
ceec520
Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: #9450 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@evanlucasevanlucas mentioned this pull request Nov 7, 2016
Merged
@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 22, 2016

should this be backported?

thefourtheye pushed a commit to thefourtheye/io.js that referenced this pull request Dec 21, 2016
@danbev@thefourtheye
build: add MAKEFLAGS="-j1" to node-gyp
4356990
Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: nodejs#9450 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@thefourtheyethefourtheye mentioned this pull request Dec 21, 2016
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@danbev@MylesBorins
build: add MAKEFLAGS="-j1" to node-gyp
43e5bd6
Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: #9450 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@danbev@MylesBorins
build: add MAKEFLAGS="-j1" to node-gyp
9703bf1
Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: #9450 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@danbev@MylesBorins
build: add MAKEFLAGS="-j1" to node-gyp
38e0f95
Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: #9450 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@danbev@MylesBorins
build: add MAKEFLAGS="-j1" to node-gyp
263cad2
Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: #9450 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@danbev@MylesBorins
build: add MAKEFLAGS="-j1" to node-gyp
33c4b16
Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: #9450 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Dec 21, 2016
Merged
Merged
@danbevdanbev deleted the supress-addons-build-warn branch January 17, 2017 07:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@cjihrigcjihrigcjihrig approved these changes

+1 more reviewer

@thefourtheyethefourtheyethefourtheye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@danbev@MylesBorins@bnoordhuis@thefourtheye@addaleax@cjihrig@nodejs-github-bot