src: default --icu_case_mapping on as a v8 option#9454
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
srl295 added the semver-minor 
jasnell approved these changes Nov 3, 2016
mscdex added i18n-api 
MemberAuthor
srl295 commented Nov 3, 2016
@evanlucas also said
|
MemberAuthor
I don't know why the linter is failing in the automated build. Can't reproduce… any ideas @nodejs/build ? update seems to be working now. |
* toLocaleUpperCase() and toLocaleLowerCase() do not function properly without this flag. * basic test case. The test case would fail if `--no_icu_case_mapping` was set. Fixes: nodejs#9445 PR-URL: nodejs#9454 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
srl295force-pushed the default_icu_case_mapping branch from a5c90e8 to 0d71729Compare
Member
bnoordhuis commented Nov 4, 2016
Could for sure, but we don't do that for other flags. |
MemberAuthor
srl295 commented Nov 4, 2016
Landed in 1a55e9a |
srl295 added a commit that referenced this pull request Nov 4, 2016
* toLocaleUpperCase() and toLocaleLowerCase() do not function properly without this flag. * basic test case. The test case would fail if `--no_icu_case_mapping` was set. Fixes: #9445 PR-URL: #9454 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
* toLocaleUpperCase() and toLocaleLowerCase() do not function properly without this flag. * basic test case. The test case would fail if `--no_icu_case_mapping` was set. Fixes: #9445 PR-URL: #9454 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
31 tasks
Contributor
landed this on v6.x and got the error "Error: unrecognized flag --icu_case_mapping" not landing for now. LMK if we should consider it |
MemberAuthor
srl295 commented Aug 31, 2017
@MylesBorins no, incompatible with older v8. And new v8 :) |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
src
Description of change
without this flag.
--no_icu_case_mappingwas set.
Fixes: #9445