build: reduce noise from doc target#9457
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The doc target currently echos the complete shell command, which might produces a lot of output. Using this change the actual commands run are still shown. Before: [ -e tools/doc/node_modules/js-yaml/package.json ] || \ [ -e tools/eslint/node_modules/js-yaml/package.json ] || \ if [ -x ./node ]; then \ cd tools/doc && ../.././node ../.././deps/npm/bin/npm-cli.js install; \ else \ cd tools/doc && node ../.././deps/npm/bin/npm-cli.js install; \ fi [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md After: [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md To verify run: $ make docclean $ make doc
nodejs-github-bot added the build 
ContributorAuthor
danbev commented Nov 4, 2016
cjihrig approved these changes Nov 4, 2016
Fishrock123 approved these changes Nov 4, 2016
jasnell approved these changes Nov 6, 2016
danbev added a commit to danbev/node that referenced this pull request Nov 7, 2016
The doc target currently echos the complete shell command, which might produces a lot of output. Using this change the actual commands run are still shown. Before: [ -e tools/doc/node_modules/js-yaml/package.json ] || \ [ -e tools/eslint/node_modules/js-yaml/package.json ] || \ if [ -x ./node ]; then \ cd tools/doc && ../.././node ../.././deps/npm/bin/npm-cli.js install; \ else \ cd tools/doc && node ../.././deps/npm/bin/npm-cli.js install; \ fi [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md After: [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md To verify run: $ make docclean $ make doc PR-URL: nodejs#9457 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James Snell <[email protected]>
ContributorAuthor
danbev commented Nov 7, 2016
Landed in: bc229d0 |
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
The doc target currently echos the complete shell command, which might produces a lot of output. Using this change the actual commands run are still shown. Before: [ -e tools/doc/node_modules/js-yaml/package.json ] || \ [ -e tools/eslint/node_modules/js-yaml/package.json ] || \ if [ -x ./node ]; then \ cd tools/doc && ../.././node ../.././deps/npm/bin/npm-cli.js install; \ else \ cd tools/doc && node ../.././deps/npm/bin/npm-cli.js install; \ fi [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md After: [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md To verify run: $ make docclean $ make doc PR-URL: #9457 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
The doc target currently echos the complete shell command, which might produces a lot of output. Using this change the actual commands run are still shown. Before: [ -e tools/doc/node_modules/js-yaml/package.json ] || \ [ -e tools/eslint/node_modules/js-yaml/package.json ] || \ if [ -x ./node ]; then \ cd tools/doc && ../.././node ../.././deps/npm/bin/npm-cli.js install; \ else \ cd tools/doc && node ../.././deps/npm/bin/npm-cli.js install; \ fi [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md After: [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md To verify run: $ make docclean $ make doc PR-URL: #9457 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
The doc target currently echos the complete shell command, which might produces a lot of output. Using this change the actual commands run are still shown. Before: [ -e tools/doc/node_modules/js-yaml/package.json ] || \ [ -e tools/eslint/node_modules/js-yaml/package.json ] || \ if [ -x ./node ]; then \ cd tools/doc && ../.././node ../.././deps/npm/bin/npm-cli.js install; \ else \ cd tools/doc && node ../.././deps/npm/bin/npm-cli.js install; \ fi [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md After: [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md To verify run: $ make docclean $ make doc PR-URL: #9457 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
build
Description of change
The doc target currently echos the complete shell command, which might
produces a lot of output. Using this change the actual commands run
are still shown.
Before:
After:
To verify run: