Skip to content

test: fix flaky test-force-repl-with-eval#9460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
santigimeno merged 1 commit into from
Nov 6, 2016
Merged

test: fix flaky test-force-repl-with-eval #9460

santigimeno merged 1 commit into from
Nov 6, 2016

Conversation

@santigimeno
Copy link
Member

@santigimenosantigimeno commented Nov 4, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Remove the timer just in case the test takes longer to complete.

It has already failed on the smartos bot: https://ci.nodejs.org/job/node-test-commit-smartos/5075/nodes=smartos14-64/consoleFull

not ok 324 parallel/test-force-repl-with-eval # /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-force-repl-with-eval.js:10 # throw new Error('timeout!'); # ^ # # Error: timeout! # at Timeout._onTimeout (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-force-repl-with-eval.js:10:9) # at ontimeout (timers.js:365:14) # at tryOnTimeout (timers.js:237:5) # at Timer.listOnTimeout (timers.js:207:5)

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 4, 2016
@santigimenosantigimeno added repl Issues and PRs related to the REPL subsystem. smartos Issues and PRs related to the SmartOS platform. labels Nov 4, 2016
Trott
Trott approved these changes Nov 5, 2016
View reviewed changes
Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@santigimeno
test: fix flaky test-force-repl-with-eval
686b334
Remove the timer just in case the test takes longer to complete. PR-URL: nodejs#9460 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@santigimenosantigimeno merged commit 686b334 into nodejs:masterNov 6, 2016
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
@santigimeno@evanlucas
test: fix flaky test-force-repl-with-eval
f640baf
Remove the timer just in case the test takes longer to complete. PR-URL: #9460 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@evanlucasevanlucas mentioned this pull request Nov 7, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@santigimeno
test: fix flaky test-force-repl-with-eval
aaf7834
Remove the timer just in case the test takes longer to complete. PR-URL: #9460 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Nov 22, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@targostargostargos approved these changes

@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

replIssues and PRs related to the REPL subsystem.smartosIssues and PRs related to the SmartOS platform.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@santigimeno@Trott@targos@cjihrig@MylesBorins@nodejs-github-bot