test: fix helper-debugger-repl.js#9486
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI.
MemberAuthor
Trott commented Nov 6, 2016
@nodejs/testing |
cjihrig approved these changes Nov 6, 2016
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
LGTM. I forget - why are the debugger tests not run on the CI? Is it because they aren't in good enough shape?
MemberAuthor
Trott commented Nov 6, 2016
Yes. |
santigimeno approved these changes Nov 6, 2016
jasnell approved these changes Nov 7, 2016
JungMinu approved these changes Nov 7, 2016
princejwesley approved these changes Nov 7, 2016
Trott added a commit to Trott/io.js that referenced this pull request Nov 10, 2016
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: nodejs#9486 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>
MemberAuthor
Trott commented Nov 10, 2016
Landed in 1323db0 |
addaleax pushed a commit that referenced this pull request Nov 22, 2016
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: #9486 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: nodejs#9486 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: #9486 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: #9486 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: #9486 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test debugger
Description of change
The test
debugger/test-debugger-repl-break-in-module(and probablyothers) was failing because the handshake message for debugging is no
longer
listening on port <port>but is insteadlistening on <address>:<port>.This change makes the check less strict so as to hopefully future-proof
it at least a little bit against subsequent changes.
This test failure is not caught in CI because currently debugger tests
are not run in CI.