doc: fix fs constants link#9508
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added doc 
There was a problem hiding this comment.
Please change commit msg headline as 'doc: fix fs constants link' and commit description is too long. Check the commit message guideline here
update: Sorry, selected the wrong review checkbox 😞
zzzzBov commented Nov 8, 2016
@princejwesley, I saw the contrib guidelines after I'd made the commit. Is there a simple way to change the commit message? |
evanlucas commented Nov 8, 2016
@zzzzBov you can run |
zzzzBov commented Nov 8, 2016
@evanlucas do I have to download the git repo to do that locally or is there a way to do that from the GitHub web interface? I literally made a two character pull request to fix a minor bug in documentation. I'm not about to jump through a bunch of hoops to make sure my 2 character change to fix documentation is properly documented. The amount I care about this pull request is so low that I'll just close it if it's too much of a bother. |
https://nodejs.org/api/fs.html#fs_fs_constants links to itself rather than to https://nodejs.org/api/fs.html#fs_fs_constants_1
Trott commented Nov 8, 2016
@zzzzBov I updated the commit message for you. (You can use |
zzzzBov commented Nov 8, 2016
@Trott, thanks for the assist! |
silverwind commented Nov 11, 2016
Thanks! Landed in 452b4dc. |
https://nodejs.org/api/fs.html#fs_fs_constants links to itself rather than to https://nodejs.org/api/fs.html#fs_fs_constants_1 PR-URL: #9508 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
https://nodejs.org/api/fs.html#fs_fs_constants links to itself rather than to https://nodejs.org/api/fs.html#fs_fs_constants_1 PR-URL: #9508 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins removed the fs https://nodejs.org/api/fs.html#fs_fs_constants links to itself rather than to https://nodejs.org/api/fs.html#fs_fs_constants_1 PR-URL: #9508 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
https://nodejs.org/api/fs.html#fs_fs_constants links to itself rather than to https://nodejs.org/api/fs.html#fs_fs_constants_1 PR-URL: #9508 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
9 participants
Checklist
Affected core subsystem(s)
doc
Description of change
https://nodejs.org/api/fs.html#fs_fs_constants links to itself rather than to https://nodejs.org/api/fs.html#fs_fs_constants_1