doc: consistent 'Returns:'#9554
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cjihrig approved these changes Nov 11, 2016
lpinca approved these changes Nov 11, 2016
Fishrock123 approved these changes Nov 11, 2016
ContributorAuthor
silverwind commented Nov 13, 2016
Thanks! Landed in 8eb19c4. |
silverwind added a commit that referenced this pull request Nov 13, 2016
For consistency, changed all `Return:` to `Returns:` in the API docs. PR-URL: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
addaleax pushed a commit that referenced this pull request Nov 22, 2016
For consistency, changed all `Return:` to `Returns:` in the API docs. PR-URL: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Contributor
MylesBorins commented Dec 13, 2016
this does not land cleanly. Would someone be willing to do a backport of the various returns work? |
ContributorAuthor
silverwind commented Dec 13, 2016
@thealphanerd it's pretty much just a find . -type f -name "*.md"| xargs sed -i "s|Return:|Returns:|g"Which branches should I target again? |
MylesBorins added a commit to MylesBorins/node that referenced this pull request Dec 21, 2016
Follow up from 8eb19c4. Lower case `return` was not updated Ref: nodejs#9554
3 tasks
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
For consistency, changed all `Return:` to `Returns:` in the API docs. PR-URL: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
For consistency, changed all `Return:` to `Returns:` in the API docs. PR-URL: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
For consistency, changed all `Return:` to `Returns:` in the API docs. PR-URL: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
For consistency, changed all `Return:` to `Returns:` in the API docs. PR-URL: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
For consistency, changed all `Return:` to `Returns:` in the API docs. PR-URL: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins added a commit that referenced this pull request Dec 23, 2016
Follow up from 8eb19c4. Lower case `return` was not updated PR-URL: #10391 Ref: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
Follow up from 8eb19c4. Lower case `return` was not updated PR-URL: #10391 Ref: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
Follow up from 8eb19c4. Lower case `return` was not updated PR-URL: #10391 Ref: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Jan 23, 2017
Follow up from 8eb19c4. Lower case `return` was not updated PR-URL: #10391 Ref: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Jan 23, 2017
Follow up from 8eb19c4. Lower case `return` was not updated PR-URL: #10391 Ref: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Jan 24, 2017
Follow up from 8eb19c4. Lower case `return` was not updated PR-URL: #10391 Ref: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Jan 24, 2017
Follow up from 8eb19c4. Lower case `return` was not updated PR-URL: #10391 Ref: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Jan 31, 2017
Follow up from 8eb19c4. Lower case `return` was not updated PR-URL: #10391 Ref: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Feb 1, 2017
Follow up from 8eb19c4. Lower case `return` was not updated PR-URL: #10391 Ref: #9554 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
We were a bit inconsistent with these. While the majority were
Return:before, I thinkReturns:is better.