test: improve test-stream2-objects.js.#9565
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
shigeki commented Nov 12, 2016
CI is running on https://ci.nodejs.org/job/node-test-pull-request/4826/ |
shigeki approved these changes Nov 12, 2016
Contributor
shigeki left a comment
shigeki left a comment There was a problem hiding this comment.
One CI error is in Centos7-64 due to missing g++ in the build environment. Others are fine.
LGTM.
shigeki suggested changes Nov 12, 2016
Contributor
shigeki left a comment
shigeki left a comment There was a problem hiding this comment.
Could you revise your commit message to describe your improvement of using strict assert checks?
ContributorAuthor
kt3k commented Nov 12, 2016
Sure, of course! |
kt3kforce-pushed the feature/improve-test-assertion-code-and-learn branch from 9ac5134 to d6819deCompareContributorAuthor
kt3k commented Nov 12, 2016
I added description of the change in commit message. |
cjihrig reviewed Nov 12, 2016
Contributor
There was a problem hiding this comment.
Could this just be assert.strictEqual(bool, i !== 5);?
cjihrig approved these changes Nov 12, 2016
This commit improves the test cases in test-stream2-objects.js by using assert.strictEqual instead of assert.equal. This is a part of Code And Learn at NodeFest 2016 nodejs/code-and-learn#58
kt3kforce-pushed the feature/improve-test-assertion-code-and-learn branch from d6819de to 24514d7Compare
lpinca approved these changes Nov 12, 2016
shigeki pushed a commit that referenced this pull request Nov 13, 2016
This commit improves the test cases in test-stream2-objects.js by using assert.strictEqual instead of assert.equal. This is a part of Code And Learn at NodeFest 2016 Fixes: nodejs/code-and-learn#58 PR-URL: #9565 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Contributor
shigeki commented Nov 13, 2016
Thanks. Landed in 8ca322d. |
ContributorAuthor
kt3k commented Nov 13, 2016
Thanks! |
addaleax pushed a commit that referenced this pull request Nov 22, 2016
This commit improves the test cases in test-stream2-objects.js by using assert.strictEqual instead of assert.equal. This is a part of Code And Learn at NodeFest 2016 Fixes: nodejs/code-and-learn#58 PR-URL: #9565 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
This commit improves the test cases in test-stream2-objects.js by using assert.strictEqual instead of assert.equal. This is a part of Code And Learn at NodeFest 2016 Fixes: nodejs/code-and-learn#58 PR-URL: nodejs#9565 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
This commit improves the test cases in test-stream2-objects.js by using assert.strictEqual instead of assert.equal. This is a part of Code And Learn at NodeFest 2016 Fixes: nodejs/code-and-learn#58 PR-URL: #9565 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
This commit improves the test cases in test-stream2-objects.js by using assert.strictEqual instead of assert.equal. This is a part of Code And Learn at NodeFest 2016 Fixes: nodejs/code-and-learn#58 PR-URL: #9565 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
This commit improves the test cases in test-stream2-objects.js by using assert.strictEqual instead of assert.equal. This is a part of Code And Learn at NodeFest 2016 Fixes: nodejs/code-and-learn#58 PR-URL: #9565 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test, stream
Description of change
This commit improves the assertions of
test-stream2-objects.js.
This is a part of Code And Learn at NodeFest 2016 Challenge
nodejs/code-and-learn#58