Skip to content

Conversation

@cjihrig
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

timers

Description of change

This commit clears the _repeat property of all timer objects in clearTimeout(). This prevents intervals passed to clearTimeout() from being rearmed.

Fixes: #9561 (although it does not directly address wrap->object() issue described in #9561 (comment))

R= @bnoordhuis

This commit clears the _repeat property of all timer objects in clearTimeout(). This prevents intervals passed to clearTimeout() from being rearmed.
@nodejs-github-botnodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Nov 14, 2016
@Fishrock123
Copy link
Contributor

I don't think this is an exhaustive patch.

unenroll() should cancel any timer callbacks without fail and Timer#close() should always stop the _handle without fail.

@Fishrock123
Copy link
Contributor

See #9561 (comment)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

timersIssues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@cjihrig@Fishrock123@nodejs-github-bot