test: fix memory leaks in malloc cctests#9667
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mscdex added the c++ 
addaleax approved these changes Nov 17, 2016
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
LGTM
Just curious, is this making any problems right now?
MemberAuthor
bnoordhuis commented Nov 17, 2016
No, not unless you run valgrind. |
cjihrig approved these changes Nov 18, 2016
santigimeno approved these changes Nov 18, 2016
jasnell approved these changes Nov 18, 2016
Make cctest valgrind-clean again by freeing heap-allocated memory. Overlooked in commit ea94086 ("src: provide allocation + nullptr check shortcuts.") PR-URL: nodejs#9667 Refs: nodejs#8482 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
bnoordhuisforce-pushed the cctest-valgrind branch from f660fa6 to b80f05eCompareaddaleax pushed a commit that referenced this pull request Nov 22, 2016
Make cctest valgrind-clean again by freeing heap-allocated memory. Overlooked in commit ea94086 ("src: provide allocation + nullptr check shortcuts.") PR-URL: #9667 Refs: #8482 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Contributor
MylesBorins commented Dec 13, 2016
@bnoordhuis should we backport this? |
Member
addaleax commented Dec 13, 2016
@thealphanerd I don’t think this applies to v4.x, but for v6 yes |
Contributor
MylesBorins commented Dec 21, 2016
@addaleax this does not land cleanly on v6, manual backport? |
Contributor
MylesBorins commented Nov 14, 2017
ping @addaleax |
Member
addaleax commented Nov 14, 2017
adding |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R=@addaleax?
CI: https://ci.nodejs.org/job/node-test-pull-request/4872/