tools: allow test.py to use full paths of tests#9694
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
princejwesley approved these changes Nov 19, 2016
Contributor
Fishrock123 commented Nov 19, 2016
gibfahn approved these changes Nov 19, 2016
Member
gibfahn left a comment
gibfahn left a comment There was a problem hiding this comment.
Looking forward to no more No tests to run because you copied the .js as well. Also tab-complete for tests is great.
ContributorAuthor
reconbot commented Nov 19, 2016
@thealphanerd freebsd failed but I can't figure out what failed, I see "no failures"
|
Contributor
failure looks infra related /cc @nodejs/build fixes #9684 |
Member
jbergstroem commented Nov 19, 2016
@thealphanerd what you meant to say was "the failure looks @jbergstroem-related". Should be fixed now. |
Contributor
MylesBorins commented Nov 19, 2016
@jbergstroem you are a hero! Thank you for all the hard infra work you do. |
Member
jbergstroem commented Nov 19, 2016
@thealphanerd thanks! if only the work wasn't so tied to fixing my other work :) |
thefourtheye suggested changes Nov 20, 2016
tools/test.py Outdated
Contributor
There was a problem hiding this comment.
Use startswith and endswith.
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix Fixes: nodejs#9684
ContributorAuthor
reconbot commented Nov 20, 2016
@thefourtheye updated to use |
thefourtheye approved these changes Nov 21, 2016
Contributor
thefourtheye left a comment
thefourtheye left a comment There was a problem hiding this comment.
Nice. LGTM. Thanks :)
gibfahn approved these changes Nov 21, 2016
Contributor
MylesBorins commented Nov 26, 2016
landed in 951ba0d |
MylesBorins pushed a commit that referenced this pull request Nov 26, 2016
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix PR-URL: #9694Fixes: #9684 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2016
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix PR-URL: #9694Fixes: #9684 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2016
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix PR-URL: #9694Fixes: #9684 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2016
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix PR-URL: #9694Fixes: #9684 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Merged
Merged
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Fixes: #9684
tools/test.pycan now take paths likeDescription of change
Slices off the
test/and the.json input files. Wildcards likeparallel/test-cluster-*will still work as will defaults.