tools: remove unneeded escaping in generate.js#9781
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`-` does not need to be escaped in a regular expression outside of character classes.
Fishrock123 approved these changes Nov 24, 2016
princejwesley approved these changes Nov 24, 2016
targos approved these changes Nov 26, 2016
Trott changed the title 
MemberAuthor
Trott commented Nov 27, 2016
doc tool code is not exercised in CI, but here's a linter run: https://ci.nodejs.org/job/node-test-linter/5394/ |
Trott added a commit to Trott/io.js that referenced this pull request Nov 27, 2016
`-` does not need to be escaped in a regular expression outside of character classes. PR-URL: nodejs#9781 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MemberAuthor
Trott commented Nov 27, 2016
Landed in fe1dcb5 |
addaleax pushed a commit that referenced this pull request Dec 5, 2016
`-` does not need to be escaped in a regular expression outside of character classes. PR-URL: #9781 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
`-` does not need to be escaped in a regular expression outside of character classes. PR-URL: #9781 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
`-` does not need to be escaped in a regular expression outside of character classes. PR-URL: #9781 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
`-` does not need to be escaped in a regular expression outside of character classes. PR-URL: #9781 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
`-` does not need to be escaped in a regular expression outside of character classes. PR-URL: #9781 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tools
Description of change
-does not need to be escaped in a regular expression outside ofcharacter classes.