doc: remove minor contradiction in debugger doc#9832
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added debugger doc 
doc/api/debugger.md Outdated
Contributor
There was a problem hiding this comment.
Why not remove "a simple" as well? The simplicity of the protocol is debated, and irrelevant to the user of the protocol anyway.
The doc says the debugger is and also isn't full-featured. Even if the sentences are talking about different things, it's confusing. `full-featured` seems superfluous in the first sentence anyway, so remove it.
gibfahn approved these changes Nov 29, 2016
cjihrig approved these changes Nov 30, 2016
mhdawson approved these changes Dec 1, 2016
Member
mhdawson left a comment
mhdawson left a comment There was a problem hiding this comment.
LGTM with change suggested by Sam.
Trott added a commit that referenced this pull request Dec 2, 2016
The doc says the debugger is and also isn't full-featured. Even if the sentences are talking about different things, it's confusing. `full-featured` seems superfluous in the first sentence anyway, so remove it. Remove a superfluous `simple` while we're at it. PR-URL: #9832 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MemberAuthor
Trott commented Dec 2, 2016
Landed in 98f9b5d |
addaleax pushed a commit that referenced this pull request Dec 5, 2016
The doc says the debugger is and also isn't full-featured. Even if the sentences are talking about different things, it's confusing. `full-featured` seems superfluous in the first sentence anyway, so remove it. Remove a superfluous `simple` while we're at it. PR-URL: #9832 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
The doc says the debugger is and also isn't full-featured. Even if the sentences are talking about different things, it's confusing. `full-featured` seems superfluous in the first sentence anyway, so remove it. Remove a superfluous `simple` while we're at it. PR-URL: nodejs#9832 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
The doc says the debugger is and also isn't full-featured. Even if the sentences are talking about different things, it's confusing. `full-featured` seems superfluous in the first sentence anyway, so remove it. Remove a superfluous `simple` while we're at it. PR-URL: #9832 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
The doc says the debugger is and also isn't full-featured. Even if the sentences are talking about different things, it's confusing. `full-featured` seems superfluous in the first sentence anyway, so remove it. Remove a superfluous `simple` while we're at it. PR-URL: #9832 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
The doc says the debugger is and also isn't full-featured. Even if the sentences are talking about different things, it's confusing. `full-featured` seems superfluous in the first sentence anyway, so remove it. Remove a superfluous `simple` while we're at it. PR-URL: #9832 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
The doc says the debugger is and also isn't full-featured. Even if the sentences are talking about different things, it's confusing. `full-featured` seems superfluous in the first sentence anyway, so remove it. Remove a superfluous `simple` while we're at it. PR-URL: #9832 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc debugger
Description of change
The doc says the debugger is and also isn't full-featured. Even if the sentences are talking about different things, it's confusing.
full-featuredseems superfluous in the first sentence anyway, soremove it.